From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 690AEC4332D for ; Thu, 19 Mar 2020 00:27:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2015720772 for ; Thu, 19 Mar 2020 00:27:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kDaLo4Uk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2015720772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AB2B86B0008; Wed, 18 Mar 2020 20:27:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A63796B009D; Wed, 18 Mar 2020 20:27:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97A5B6B00A4; Wed, 18 Mar 2020 20:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 7CE936B0008 for ; Wed, 18 Mar 2020 20:27:41 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 353B5824556B for ; Thu, 19 Mar 2020 00:27:41 +0000 (UTC) X-FDA: 76610223522.20.bomb78_602ebf9d8f04b X-HE-Tag: bomb78_602ebf9d8f04b X-Filterd-Recvd-Size: 4805 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 00:27:40 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id g16so355011qtp.9 for ; Wed, 18 Mar 2020 17:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eGiBXBXEDUzqEngMURydWzlDzsGVXTSu9Q8fyVOnE6M=; b=kDaLo4UkT+D2r1PdCkIi6+BQizLjkCVHdeZOUuEhDy+fPDI1Bph26PQ2uzgajFrB5Q qbDQsHkZfIvl5/4k/s1/oMvOhtBU2hB26r9onFWfyXFfbpbJ5pnLNtTYp9izunI+uT/l /lnzojERmzYrNse6ZCIJJZD4lORJEZ1IS+/j27qs0RBLyOIBUVTgPtiuaWnNej8rDSgW yJI5sTOqcLm3UJWDiWbL8bB1K0hyjL/mSoL7wt1l3wy3b8GvN7RW58CkCDznuV4i43Pj Y3wgedkebZENiT66sjY2XeMmZIxNmy7oY2zYYG8mWK27CPA0VlgXTlEWSy7f9/JXG3l5 X5jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eGiBXBXEDUzqEngMURydWzlDzsGVXTSu9Q8fyVOnE6M=; b=gwina41H9vaAhH7vo+mm48rltc3DogsKe5+xXZyUaFk2l1fVvwjYxzBaEfkegChFPR SDtjtLV88CPGzk/vf+5O/0PrMF3VLk+8R5uGpQS7FztI9ng5JJ48xm78H2aw0f5XYe56 D0T43y89x1Exi/5cL2MY0doTJJ/PMNi5Wv5SSryZU3fQ4NZAVx0Qizalf0/TWtbXV4T6 VB8MUvmyJW8kTSqcBLDAjuSkHRxPS0JP9S2+fw6CrYk6YwalUcH0BX5Gsj9GcVUYK/OC +Y0SIHiMIXHd1UBq0SG8af0/R7MUepkzzJfiAntJV1MDVa5b+8o/ifa/CJZFb/NkQr5s urvA== X-Gm-Message-State: ANhLgQ0J3BCa+St2mEmmqBO5IFizggIdHXew4iNtUcUiHS51hGsRbRzd 3GMdtxwsvccnkIcUxCnoo6yWgg== X-Google-Smtp-Source: ADFU+vtQDjxKhs73+ZZo129JqYXotciPR9LAYpGGEMznxE9y+pyreMj5scT1H9f6fx9u+BzSm6Z1yQ== X-Received: by 2002:aed:3eec:: with SMTP id o41mr366215qtf.343.1584577660169; Wed, 18 Mar 2020 17:27:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id b6sm303469qtj.15.2020.03.18.17.27.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Mar 2020 17:27:39 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jEj2B-00026M-03; Wed, 18 Mar 2020 21:27:39 -0300 Date: Wed, 18 Mar 2020 21:27:38 -0300 From: Jason Gunthorpe To: Christoph Hellwig Cc: Jerome Glisse , Ralph Campbell , linux-mm@kvack.org Subject: Re: misc hmm cleanups Message-ID: <20200319002738.GF20941@ziepe.ca> References: <20200316135310.899364-1-hch@lst.de> <20200317183823.GU20941@ziepe.ca> <20200317185537.GA20962@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317185537.GA20962@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 17, 2020 at 07:55:37PM +0100, Christoph Hellwig wrote: > On Tue, Mar 17, 2020 at 03:38:23PM -0300, Jason Gunthorpe wrote: > > On Mon, Mar 16, 2020 at 02:53:05PM +0100, Christoph Hellwig wrote: > > > Hi Jason, > > > > > > I started looking at bits in my backlog that shouldn't get too much > > > in your way. Here is a bunch of simple patches, on top of the series > > > you sent out. > > > > I applied these two, I made the edits discussed to the last two > > patches, and ran the series over the hmm tester Ralph has. > > > > Please take a quick check: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=2a60cfb32b260468dc81dfc1f56fc0f9ebe9f2e5 > > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=ee37d9e6e47439fbd3a72b7c6a13b8ce216fb125 > > > > - Edited commit message to point out that the NONE set is a bug and > > add fixes line. > > - Drop the pfn error and update the commit message, remove now unused > > pfn and i vars > > I wonder if just having those fixes as separate commits would have > been more clear. But the updated patches do look correct to me. Ok, I agree the last one removing the pfns is a bit of overreach, even if the -EPERM exit looks bad when it is de-inlined. I will sort it in a following patch I like the NONE one though So, I swapped the last back to your original I hope to rebase some of my remaining series tomorrow. Things are crazy here right now. https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=ede58c05bec9e5ccf659cf001bb969963806bed0 Thanks, Jason