From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F81C4332B for ; Thu, 19 Mar 2020 10:15:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 98569206D7 for ; Thu, 19 Mar 2020 10:15:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="e1D36JWP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98569206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BAC36B0003; Thu, 19 Mar 2020 06:15:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26B316B0005; Thu, 19 Mar 2020 06:15:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 181296B0006; Thu, 19 Mar 2020 06:15:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id F33626B0003 for ; Thu, 19 Mar 2020 06:15:03 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A7EFB246B for ; Thu, 19 Mar 2020 10:15:03 +0000 (UTC) X-FDA: 76611703686.05.cover67_8375a5f03e514 X-HE-Tag: cover67_8375a5f03e514 X-Filterd-Recvd-Size: 2225 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 10:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fzGXx+1YD+UsxMXs5xesPee/F01EYH9TBYq9aMWzzmg=; b=e1D36JWP76KB9N+RTMzTps4TRx GZGUXZrq05jJZtkwPmx5vnwLHNHRwm35MlVx+HTIZdjzTgH7TFYUqgEgz0zIkw4+Hbqz0RlrrOZpj NVNxy/1g4gIbxMCWK2n8qYoD1s2Sb5fs3kO/qPXo+Q5OBHA4FIZddsCxP2DxSvT2prgcXsQdyRhRT UQLIdYYBndaxsh2U6ZVkJkpze4Gn8a4CSVeEIG+cR+qZk79U0EpPlkE95kshfMkDn5W/proJdptRN Ge0IcK8MYj+qjstzh5X8xGmmSRr7j4IVsicXTNwx9AU2gNWA4BXJeUpzJ4BtkKFjjn0YK0/K0WZzx fyphhINg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEsCb-0001Di-UP; Thu, 19 Mar 2020 10:15:01 +0000 Date: Thu, 19 Mar 2020 03:15:01 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-mm@kvack.org Subject: Re: [PATCH v2 2/8] mm: Rename arguments to find_subpage Message-ID: <20200319101501.GA3590@infradead.org> References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318140253.6141-3-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 18, 2020 at 07:02:47AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > This isn't just a random struct page, it's known to be a head page, > and calling it head makes the function better self-documenting. > The pgoff_t is less confusing if it's named index instead of offset. > Also add a couple of comments to explain why we're doing various things. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig