From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE783C4332D for ; Thu, 19 Mar 2020 10:19:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ACFBD206D7 for ; Thu, 19 Mar 2020 10:19:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fUUf+Lyq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ACFBD206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6137B6B0006; Thu, 19 Mar 2020 06:19:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C2EA6B0007; Thu, 19 Mar 2020 06:19:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D90D6B0008; Thu, 19 Mar 2020 06:19:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 339A36B0006 for ; Thu, 19 Mar 2020 06:19:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id F0DFE180AD81F for ; Thu, 19 Mar 2020 10:19:12 +0000 (UTC) X-FDA: 76611714144.29.bean34_163b94dbfb94b X-HE-Tag: bean34_163b94dbfb94b X-Filterd-Recvd-Size: 2407 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 10:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/TePV6NI2Btpaa3wgd/OcTsJB47Ji0v+gKOwroxaN9Y=; b=fUUf+LyqhKG0q3JsIoxx6BWv4X N2/SXkTBUFnSwvw6Uq1A7qrpcu19zryXFonKHTenaO1nPZGvISGRPguaNzIrYmtpx0IqLHUSbmn0w bqhUlyGJ2W2p4i/lWJRfeQu8c3uJaQxE+18+pummIpJDAjVUhrANH6w9IbageSL17j2koLcZmS+6G jYnF7JqE2GOe1AgxCa9cMGhtRo2lqirE40xUJq5Riet6ryk3DCmNgaqZzA8FJJklrx/xwj+M2HmTt YrZluU0rQ5BBHagM71UZ3KI2k/M3bDq4njHQwsKwK2k4km7b5cyuYQ2avH8tWoC61GEUlAaSgnr9c CD3ptO2A==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEsGd-0002ot-IM; Thu, 19 Mar 2020 10:19:11 +0000 Date: Thu, 19 Mar 2020 03:19:11 -0700 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-mm@kvack.org, "Kirill A . Shutemov" Subject: Re: [PATCH v2 8/8] mm: Rewrite pagecache_get_page documentation Message-ID: <20200319101911.GD3590@infradead.org> References: <20200318140253.6141-1-willy@infradead.org> <20200318140253.6141-9-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318140253.6141-9-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 18, 2020 at 07:02:53AM -0700, Matthew Wilcox wrote: > From: "Matthew Wilcox (Oracle)" > > - These were never called PCG flags; they've been called FGP flags since > their introduction in 2014. > - The FGP_FOR_MMAP flag was misleadingly documented as if it was an > alternative to FGP_CREAT instead of an option to it. > - Rename the 'offset' parameter to 'index'. > - Capitalisation, formatting, rewording. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Kirill A. Shutemov Looks good, Reviewed-by: Christoph Hellwig