From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3246AC4332D for ; Fri, 20 Mar 2020 11:47:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E8C442076E for ; Fri, 20 Mar 2020 11:47:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="EOqCghog" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8C442076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 874EE6B0003; Fri, 20 Mar 2020 07:47:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 826AD6B0006; Fri, 20 Mar 2020 07:47:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714AD6B0007; Fri, 20 Mar 2020 07:47:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 57E0C6B0003 for ; Fri, 20 Mar 2020 07:47:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0C5D5180AD807 for ; Fri, 20 Mar 2020 11:47:41 +0000 (UTC) X-FDA: 76615565922.23.coach56_7d3fc21fc6445 X-HE-Tag: coach56_7d3fc21fc6445 X-Filterd-Recvd-Size: 4941 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 11:47:40 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id n20so4261771lfl.10 for ; Fri, 20 Mar 2020 04:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M2TXgqwUodKIYzZQJAh9II3qf8XBdi90z3brsAgVKrM=; b=EOqCghogEmGJ1fsAFS0IHYdEmNQzGmBdIKU7jeXqBFhTiR8LxaFQ+MDWLVgLshqjzJ 9OeqePbgK4sWKU7KOBt7auRlj28cHFFQtDC6XsiTMbAHMJmZbnr+Neuik7VeKx4OfGvI ZK5UMK2IikgllUw17HLgo6N/9nyEd92UfQFjdECjbsm/XroryWTYiRwKpK61AhiH1AWn IOpozrLzcemPCfHaDNd9ubTDsN746O9i9Tl3y9OmQAVvc8Lveg3cPfk++YOWEpDp/7tY y2uqzMfnBxkeHJjxFc20DS3l5iW8n+jLgmGamBDOhai/PbP20em6JUFxLeAS+8Gbotb4 vkUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M2TXgqwUodKIYzZQJAh9II3qf8XBdi90z3brsAgVKrM=; b=CAaw2OMNtzTeOLrap4qFXj2Qg1nDaJDk1oy5ssl5tekIfpZ1jD1H0cf4y+24r/jpgu esx6arwuzojgRa6h+sfAc5oL/zWRvn1ZdugUbAdm+VjJG3Y6FjYk7qLJBTMcOe50bbqe JUS8Y/b8jNw3ur5LDz5GTwqPdPzSJQcV2BmWtdeW30i6u+D+GIDIAebraSzyJWIbAFWM iHoWNfQSMH3b8ZofojIBql7WyzSAYm+2ztOr3TnbLetKxzJ62B0J9OfL4LADW7TjE7t+ rSLjD36s2hts08MCgZnO4M+qPROihigk/Tagw6xW7lbnnVEnj1hsEqKjIHFMJ06roRBL CJVg== X-Gm-Message-State: ANhLgQ3aBy7Geibq34j2ztXyt/UyJJ+8lgdRHJHzuE3EO0+Gz6WTa9Pm cBb4ED8J1b4+ZGf+08EYXPIlYw== X-Google-Smtp-Source: ADFU+vv2hj54FnbwzFhCeK1QseTOS3XEPe8XbkB7Ucp0Rt2uShXeQvecyNxv0o40/OLXqhrVGw9gCw== X-Received: by 2002:ac2:5c5d:: with SMTP id s29mr787973lfp.129.1584704859333; Fri, 20 Mar 2020 04:47:39 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b23sm3315212lff.64.2020.03.20.04.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 04:47:38 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 09E221020EE; Fri, 20 Mar 2020 14:47:42 +0300 (+03) Date: Fri, 20 Mar 2020 14:47:41 +0300 From: "Kirill A. Shutemov" To: Anshuman Khandual Cc: linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Dave Hansen , Andrew Morton , x86@kernel.org, linux-kernel@vger.kernel.org, Dan Williams Subject: Re: [PATCH] x86/mm: Make pud_present() check _PAGE_PROTNONE and _PAGE_PSE as well Message-ID: <20200320114741.c62iolt2yzltnscf@box> References: <1584507679-11976-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 20, 2020 at 08:53:16AM +0530, Anshuman Khandual wrote: > > > On 03/18/2020 10:31 AM, Anshuman Khandual wrote: > > pud_present() should also check _PAGE_PROTNONE and _PAGE_PSE bits like in > > case pmd_present(). This makes a PUD entry test positive for pud_present() > > after getting invalidated with pud_mknotpresent(), hence standardizing the > > semantics with PMD helpers. > > > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: "H. Peter Anvin" > > Cc: Dave Hansen > > Cc: Andrew Morton > > Cc: x86@kernel.org > > Cc: linux-mm@kvack.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Anshuman Khandual > > --- > > Even though pud_mknotpresent() is not used any where currently, there is > > a discrepancy between PMD and PUD. > > > > WARN_ON(!pud_present(pud_mknotpresent(pud_mkhuge(pud)))) -> Fail > > WARN_ON(!pmd_present(pmd_mknotpresent(pmd_mkhuge(pmd)))) -> Pass > > > > Though pud_mknotpresent() currently clears _PAGE_PROTNONE, pud_present() > > does not check it. This change fixes both inconsistencies. > > > > This has been build and boot tested on x86. > > Adding Kirill and Dan. > > +Cc: Kirill A. Shutemov > +Cc: Dan Williams Or we can just drop the pud_mknotpresent(). There's no users AFAICS and only x86 provides it. -- Kirill A. Shutemov