From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC1D0C4332D for ; Fri, 20 Mar 2020 15:55:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7744E20709 for ; Fri, 20 Mar 2020 15:55:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="h9BpRW81" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7744E20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC0946B000C; Fri, 20 Mar 2020 11:55:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E708D6B000D; Fri, 20 Mar 2020 11:55:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D85CB6B000E; Fri, 20 Mar 2020 11:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id BF8636B000C for ; Fri, 20 Mar 2020 11:55:09 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 557D36D8C for ; Fri, 20 Mar 2020 15:55:09 +0000 (UTC) X-FDA: 76616189538.11.ghost88_67260fc38835f X-HE-Tag: ghost88_67260fc38835f X-Filterd-Recvd-Size: 4567 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 15:55:08 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id o18so3208750qvf.1 for ; Fri, 20 Mar 2020 08:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kA54VswZsT5/CNlwIwZBY/H30VVL/ablHOI+ykDEfUw=; b=h9BpRW81+Xm0pLBVCmKH2IdQD4VSOMFNFWYiZwvPVdobwa/P6HtGQIJtQXZJXU5CLz qStLK2ZD5vaYWKNyFsI+0O7m7raDmTcfNQd55TxjcluITF+TqXPXWxIhrfuLMEASvnf1 AWwe3LDrYTmqVPTDdtP3tKgwpar+TRSFwjRRXqBxfWp62gXvUBPt/nWvu9lPQhjOnOMt XDxekKzMPuj3xlrxEWmTLZIh3ki9YqmWRQWZZS3ILij5BEMMD4iArLkNYJPGq1hz3gr3 YKJvqGki+efSkGuckkUDGK2qUr6vAI8G0OS72Xb530svwx80KSuJ4t1fAcZ6bsIDySzO TmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kA54VswZsT5/CNlwIwZBY/H30VVL/ablHOI+ykDEfUw=; b=XzRNEeTGu3Axkj5slvkEwERyTqG5ebN7HQ+/I0XKYfCvl2g651fRP4ZDPXqtxmihQT Uedf8Rbftc5PLBvq6zrM8uKIVHNbM4YKDMUiMAvysxhuLfA5c5CeLyYH1Rq3Icg+0Jgd p81cmBgZjrBeWLWZrqMIHtCG0bBJY/3AfMLVYaHb9lhzbrCb6QH8AfoTRbHrlocv96AR bU29GXMM1IHVAHO9nqvOcBE8zSRyCA+7evhca4PeaU7XbInCR/Z0CqRN++L9zSsmCOt5 ZZOIHGW42xX050Qoqv6oO593Najj5e5Gj6hFflp+j1RhPVYuzzQyG3TQO6F0/JhkseeQ pKoA== X-Gm-Message-State: ANhLgQ00JOHWEFx2/qw2iH8/3vxLbUAr8xGRNQKnct8yTmXSeBqmKSA0 FvpUIZuApapg0jBYgEOJUcGHRA== X-Google-Smtp-Source: ADFU+vveo0N4CHbisUB5ArxqhCh+Kdu2UDfHtyEOWTY+K6g/iOG43vJUwa4Ie5ooLXrDSnkymo6JZw== X-Received: by 2002:a0c:d601:: with SMTP id c1mr4222390qvj.164.1584719707712; Fri, 20 Mar 2020 08:55:07 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:a9a9]) by smtp.gmail.com with ESMTPSA id c40sm5218215qtk.18.2020.03.20.08.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 08:55:06 -0700 (PDT) Date: Fri, 20 Mar 2020 11:55:05 -0400 From: Johannes Weiner To: Michal Hocko Cc: mateusznosek0@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment Message-ID: <20200320155505.GA204561@cmpxchg.org> References: <20200319165938.23354-1-mateusznosek0@gmail.com> <20200319171334.GK20800@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319171334.GK20800@dhcp22.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 19, 2020 at 06:13:34PM +0100, Michal Hocko wrote: > It is usually preferable to Cc author of the code (added Johannes) > > On Thu 19-03-20 17:59:38, mateusznosek0@gmail.com wrote: > > From: Mateusz Nosek > > > > Previously 0 was assigned to 'sc->skipped_deactivate'. It could happen only > > if 'sc->skipped_deactivate' was 0 so the assignment is unnecessary and can > > be removed. > > The above wording was a bit hard to understdand for me. I would go with > " > sc->memcg_low_skipped resets skipped_deactivate to 0 but this is not > needed as this code path is never reachable with skipped_deactivate != 0 > due to previous sc->skipped_deactivate branch. > " Yeah that sounds good. > > Signed-off-by: Mateusz Nosek > > The patch is correct. I am not sure it results in a better code though. > I will defer to Johannes here. I suspect he simply wanted to express > that skipped_deactivate should be always reset when retrying the direct > reclaim. After this patch this could be lost in future changes so the > code would be more subtle. But I am only guessing here. It's a valid concern, but I think in this case specifically we're very unlikely to change the ordering here - violate memory.low before going after active pages of unprotected cgroups. I indeed just kept it stupid: reset everything, then retry. But it appears that the unnecessary assignment trips people up and wastes their time, so I'm in favor of removing it. Acked-by: Johannes Weiner