From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8F81C4332B for ; Fri, 20 Mar 2020 17:34:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8B74B20722 for ; Fri, 20 Mar 2020 17:34:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iyOebHzv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B74B20722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 378746B0005; Fri, 20 Mar 2020 13:34:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 302A26B0008; Fri, 20 Mar 2020 13:34:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CA726B000C; Fri, 20 Mar 2020 13:34:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 01C156B0005 for ; Fri, 20 Mar 2020 13:34:08 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86EDA248E for ; Fri, 20 Mar 2020 17:34:08 +0000 (UTC) X-FDA: 76616438976.05.bag17_5e562831ef830 X-HE-Tag: bag17_5e562831ef830 X-Filterd-Recvd-Size: 3618 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Fri, 20 Mar 2020 17:34:08 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id q19so7277406ljp.9 for ; Fri, 20 Mar 2020 10:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=of48erB0S8cHeslTdzECLL0UR5qKqtxYepkriqnz45s=; b=iyOebHzva1NGNHGpqdCghDoH/dfwvxHleVANO6ewDmxSnY2X1xXz/vCAQiQ1LBCswx NbmnNapPbzh7QzdNPNBfJ2o3N3cXi7QLzBDF80dW7s4lfEbyz6OiDJkCWsOLasaBrXep eGPiHvbsmuITMkJDr9uRLy9Jb/w0+lufqGBTWMC/cDodkdSGU+k7ebakOHP2bzKe6vCv q8Rwp8QAKfCWnkh7Ry+UDUCwXVsuAv+oCK27KoD2K3+XVjWPH2BaImUS6h4y7YSr9b8+ yxSJie5c8zBudGonz6RdZsr1DNm5I9S5fCdaw2B3F3Fkwhn66CavGkfS7yC5hoXbEBIt f4bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=of48erB0S8cHeslTdzECLL0UR5qKqtxYepkriqnz45s=; b=CuiaixHqauw203aY72dbmMYlETAQiQXsB68tHdHqcwt43rYrdE/lpjYtFmYUS8VeCb TLlH+ntGHh4BFoy8GjTpFpO3GrrcmolWL8kLVnP7a+guY/CeTpvsVesAipM3IYJuyV9L ncGlVPwOvzf+hur1gIh8trYpX278bBZyIaSrKzIURDDLKn7bnn3jDE59GcT1MlWUk/+U IGuhNA8vGyVJuvN/+i9FY5WmE0ADOKIYq0xXfcI1VBgABnA9ENoomSPy2YQ5IwLYnnTV 9r4YRwj5BkBxlpbl1YYqmu1RYHUeML7IJWZYTp5lhGxPOjpUboWCEx4YUxZ9uK15dwbQ iO6w== X-Gm-Message-State: ANhLgQ1RVN9FqWGgVBgi8DPCGfEIbZjJDoxsVgTDpxIb2Kyjpy7hkaCF ZajUcjj70V1SRPjTAI/PGxcX2OH4 X-Google-Smtp-Source: ADFU+vtDzPH9ZgT/w73DsnlnfyslYS9eCf56nWJqC/bXo01479mNv2Jg3uh+5x48fZ5RmKoOCeV/bA== X-Received: by 2002:a2e:6e13:: with SMTP id j19mr5785456ljc.253.1584725646438; Fri, 20 Mar 2020 10:34:06 -0700 (PDT) Received: from localhost.localdomain (188.146.97.196.nat.umts.dynamic.t-mobile.pl. [188.146.97.196]) by smtp.gmail.com with ESMTPSA id 24sm279334ljv.105.2020.03.20.10.34.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Mar 2020 10:34:05 -0700 (PDT) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [PATCH] mm/dmapool.c: micro-optimisation remove unnecessary branch Date: Fri, 20 Mar 2020 18:33:17 +0100 Message-Id: <20200320173317.26408-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Previously there was a check if 'size' is aligned to 'align' and if not then it was aligned. This check was expensive as both branch and division are expensive instructions in most architectures. 'ALIGN' function on already aligned value will not change it, and as it is cheaper than branch + division it can be executed all the time and branch can be removed. Signed-off-by: Mateusz Nosek --- mm/dmapool.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index fe5d33060415..f9fb9bbd733e 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -144,9 +144,7 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, else if (size < 4) size = 4; - if ((size % align) != 0) - size = ALIGN(size, align); - + size = ALIGN(size, align); allocation = max_t(size_t, size, PAGE_SIZE); if (!boundary) -- 2.17.1