From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9AC6C4332E for ; Sat, 21 Mar 2020 08:39:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9F44520739 for ; Sat, 21 Mar 2020 08:39:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F44520739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51A826B0007; Sat, 21 Mar 2020 04:39:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CA1E6B0008; Sat, 21 Mar 2020 04:39:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 406AC6B000A; Sat, 21 Mar 2020 04:39:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 25D616B0007 for ; Sat, 21 Mar 2020 04:39:05 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id AA096181AEF0B for ; Sat, 21 Mar 2020 08:39:04 +0000 (UTC) X-FDA: 76618719408.28.year84_896b209bfa95f X-HE-Tag: year84_896b209bfa95f X-Filterd-Recvd-Size: 1698 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Mar 2020 08:39:04 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 5948068AFE; Sat, 21 Mar 2020 09:39:02 +0100 (CET) Date: Sat, 21 Mar 2020 09:39:02 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , Ralph Campbell , Felix.Kuehling@amd.com, linux-mm@kvack.org, John Hubbard , dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Christoph Hellwig , Philip Yang , Jason Gunthorpe Subject: Re: [PATCH hmm 3/6] mm/hmm: remove unused code and tidy comments Message-ID: <20200321083902.GC28695@lst.de> References: <20200320164905.21722-1-jgg@ziepe.ca> <20200320164905.21722-4-jgg@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320164905.21722-4-jgg@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 20, 2020 at 01:49:02PM -0300, Jason Gunthorpe wrote: > From: Jason Gunthorpe > > Delete several functions that are never called, fix some desync between > comments and structure content, remove an unused ret, and move one > function only used by hmm.c into hmm.c This looks good: Signed-off-by: Christoph Hellwig Btw, the top of file comment in include/linux/hmm.h really needs some work as well. In fact I think it should be mostly removed with any remaining useful bit moved to Documentation/vm/hmm.rst.