From: Chris Down <chris@chrisdown.name>
To: Hui Zhu <teawater@gmail.com>
Cc: hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, hughd@google.com,
yang.shi@linux.alibaba.com, kirill@shutemov.name,
dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com,
sean.j.christopherson@intel.com, thellstrom@vmware.com,
guro@fb.com, shakeelb@google.com, tj@kernel.org,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-mm@kvack.org,
Hui Zhu <teawaterz@linux.alibaba.com>
Subject: Re: [PATCH] mm, memcg: Add memory.transparent_hugepage_disabled
Date: Tue, 24 Mar 2020 13:23:50 +0000 [thread overview]
Message-ID: <20200324132350.GA7528@chrisdown.name> (raw)
In-Reply-To: <1585045916-27339-1-git-send-email-teawater@gmail.com>
Hui Zhu writes:
>/sys/kernel/mm/transparent_hugepage/enabled is the only interface to
>control if the application can use THP in system level.
>Sometime, we would not want an application use THP even if
>transparent_hugepage/enabled is set to "always" or "madvise" because
>thp may need more cpu and memory resources in some cases.
>
>This commit add a new interface memory.transparent_hugepage_disabled
>in memcg.
>When it set to 1, the application inside the cgroup cannot use THP
>except dax.
I'm against this patch even in the abstract -- this adds an extremely niche use
case to a general interface, and there are plenty of ways to already indicate
THP preference.
Perhaps there is some new interface desirable for your use case, but adding a
new global file to memcg certainly isn't it.
prev parent reply other threads:[~2020-03-24 13:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 10:31 [PATCH] mm, memcg: Add memory.transparent_hugepage_disabled Hui Zhu
2020-03-24 11:00 ` Michal Hocko
2020-03-24 12:30 ` teawater
2020-03-24 13:17 ` Michal Hocko
2020-03-24 12:17 ` Kirill A. Shutemov
2020-03-24 19:17 ` David Rientjes
2020-03-24 13:23 ` Chris Down [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324132350.GA7528@chrisdown.name \
--to=chris@chrisdown.name \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=cgroups@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=sean.j.christopherson@intel.com \
--cc=shakeelb@google.com \
--cc=teawater@gmail.com \
--cc=teawaterz@linux.alibaba.com \
--cc=tglx@linutronix.de \
--cc=thellstrom@vmware.com \
--cc=tj@kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).