From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15107C43331 for ; Thu, 26 Mar 2020 00:54:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BD54120772 for ; Thu, 26 Mar 2020 00:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tU0ERJPp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD54120772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 645F46B000A; Wed, 25 Mar 2020 20:54:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F5C76B000C; Wed, 25 Mar 2020 20:54:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 50B3B6B000D; Wed, 25 Mar 2020 20:54:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id 369086B000A for ; Wed, 25 Mar 2020 20:54:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 15FF8180AD815 for ; Thu, 26 Mar 2020 00:54:36 +0000 (UTC) X-FDA: 76635692952.11.rake33_b07c9df43630 X-HE-Tag: rake33_b07c9df43630 X-Filterd-Recvd-Size: 3116 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 26 Mar 2020 00:54:35 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BD792076A; Thu, 26 Mar 2020 00:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585184074; bh=2Zza7Ws50Ivb9FxN1+3Mi08ifu2PHHXCJRG53MpeYmU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tU0ERJPpov3aJnBt3QmEgN6W2lPVjvLis4a1bAuhkAnQzLya6dj+OkK1TeC1QRjTW cPVgeaClxChp5AnkvNfCm51opbxtv37XXmvWJYXObSYJ++HmffEWSZE/AAVmiYw/1L sTSJ1MZVFtGu/Csl+oj83RHgAB3Jcv1nCxT8yH9c= Date: Wed, 25 Mar 2020 17:54:33 -0700 From: Andrew Morton To: Vlastimil Babka Cc: linux-mm@kvack.org, Joonsoo Kim , Bharata B Rao , Christopher Lameter , David Rientjes , Kirill Tkhai , Mel Gorman , Michael Ellerman , Michal Hocko , Nathan Lynch , Pekka Enberg , PUVICHAKRAVARTHY RAMACHANDRAN , Sachin Sant , Srikar Dronamraju Subject: Re: [PATCH 2/2] Revert "topology: add support for node_to_mem_node() to determine the fallback node" Message-Id: <20200325175433.d5ff1aeecfc7759e66c3898f@linux-foundation.org> In-Reply-To: References: <20200320115533.9604-1-vbabka@suse.cz> <20200320115533.9604-2-vbabka@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 24 Mar 2020 14:00:52 +0100 Vlastimil Babka wrote: > On 3/20/20 12:55 PM, Vlastimil Babka wrote: > > This reverts commit ad2c8144418c6a81cefe65379fd47bbe8344cef2. > > > > The function node_to_mem_node() was introduced by that commit for use in SLUB > > on systems with memoryless nodes, but it turned out to be unreliable on some > > architectures/configurations and a simpler solution exists than fixing it up. > > > > Thus the previous commit "mm, slub: prevent kmalloc_node crashes and memory > > leaks" removed the only user of node_to_mem_node() and we can revert the commit > > that introduced it. > > Since the bugfix was fast-tracked to Linus, we can now reference it properly and > replace the second paragraph with: > > Thus commit 0715e6c516f1 ("mm, slub: prevent kmalloc_node crashes and memory > leaks") removed the only user of node_to_mem_node() and we can revert the commit > that introduced the function. I updated the changelog, thanks.