From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1343CC2D0E5 for ; Fri, 27 Mar 2020 12:11:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id ABD6F2074F for ; Fri, 27 Mar 2020 12:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ex3D0PnD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABD6F2074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 087106B0010; Fri, 27 Mar 2020 08:11:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 010D86B0032; Fri, 27 Mar 2020 08:11:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E19EC6B0036; Fri, 27 Mar 2020 08:11:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id C55676B0010 for ; Fri, 27 Mar 2020 08:11:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 31A64824556B for ; Fri, 27 Mar 2020 12:11:04 +0000 (UTC) X-FDA: 76641026448.03.rock24_94d6f7e3b50e X-HE-Tag: rock24_94d6f7e3b50e X-Filterd-Recvd-Size: 4149 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Fri, 27 Mar 2020 12:11:03 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id 139so569429qkd.9 for ; Fri, 27 Mar 2020 05:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ae32xXO67Uei3DTimjBj1wlAZ/pkH/el6Qiul9IT/30=; b=Ex3D0PnD7gDl3aSUB2klXnKG6WqRJ7QfwnM6N9ZGFL92WovcOuAzEFRyYweVO4bxtE 7Xg8gqSK2Z3BuI8TP9K0fdhDNWpdwzHD/JkAmE9cJPZ0tZrDsJOHhAbWsH+vjsmkuIY6 uwK5871CUpjZLzSstezfN/aBg5CasNqsGxP8A9EfPWuZRYdJDyWQBXQ7ttS6IiSCsthL ifCas0C0YCZ3fC4iuuQORU9gg8EUmyeqhcf3rCO0NRXcZ2xj0HrGTKS3hd6SWnksKhsW VFFIjipCV/rNC4HQApb3Vkke+23D5s7p4BGXZmNMTKFYNFv1sR1pllPZ8YXvdvs0uPyV 9Few== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ae32xXO67Uei3DTimjBj1wlAZ/pkH/el6Qiul9IT/30=; b=fHYiSFFPYONHG0U3Vem4q1U2RjfNH6LzQKzYdl79ABkcxLVv5fKKN784BwQ5Td0HNR EwU0AA2emCkkEJk5L2s9R5rSucvZusqtQWKKAuySGZvzY61dbkZo2DcqFLvUShKc3lwv v1useRrHEURESmqiJvA/uiDUFVtZFJ/9yaFWR/sVjuWivJUCEKnBM5+2UpW77L/mlMmY k3H18lwrDqo0Yn+uFWkCnCA5G0Tt5eOSEILQIoqc6CpEtDtqLKL/rlTX1xI4J98Zioi7 zOqOGgWA50wbD6rFKksCT7mOo/XU16uL+y2ZFccN7/+h/3j783myFonb2l2Lc79x8aop /VyQ== X-Gm-Message-State: ANhLgQ0uFVAIBFlYlXUj/JZg3J68jgsh7+gPwkIWdL4U27y9Avrq8evf CIEeRseWTwja9Cbj13yUpBO4dw== X-Google-Smtp-Source: ADFU+vu5etCsTsz6Y5TtfPSyk7GQigfbQaUBOkfH75rGPq30AeujH7DUKAa3E9WYmWw4syrKT0bbug== X-Received: by 2002:a37:a746:: with SMTP id q67mr14014729qke.215.1585311063288; Fri, 27 Mar 2020 05:11:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id t71sm3539359qke.55.2020.03.27.05.11.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 05:11:02 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jHnpE-0007MU-MC; Fri, 27 Mar 2020 09:11:00 -0300 Date: Fri, 27 Mar 2020 09:11:00 -0300 From: Jason Gunthorpe To: "Longpeng(Mike)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, arei.gonglei@huawei.com, weidong.huang@huawei.com, weifuqiang@huawei.com, kirill.shutemov@linux.intel.com, Mike Kravetz , Andrew Morton , Matthew Wilcox , Sean Christopherson , stable@vger.kernel.org Subject: Re: [PATCH v3] mm/hugetlb: fix a addressing exception caused by huge_pte_offset Message-ID: <20200327121100.GR20941@ziepe.ca> References: <20200327014007.1915-1-longpeng2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200327014007.1915-1-longpeng2@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 27, 2020 at 09:40:07AM +0800, Longpeng(Mike) wrote: > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index dd8737a..d4fab68 100644 > +++ b/mm/hugetlb.c > @@ -4909,29 +4909,33 @@ pte_t *huge_pte_offset(struct mm_struct *mm, > unsigned long addr, unsigned long sz) > { > pgd_t *pgd; > - p4d_t *p4d; > - pud_t *pud; > - pmd_t *pmd; > + p4d_t *p4g, p4d_entry; > + pud_t *pud, pud_entry; > + pmd_t *pmd, pmd_entry; > > pgd = pgd_offset(mm, addr); > if (!pgd_present(*pgd)) > return NULL; > - p4d = p4d_offset(pgd, addr); > - if (!p4d_present(*p4d)) > + > + p4g = p4d_offset(pgd, addr); Why p4g here? Shouldn't it be p4d? Jason