From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3572C2BA1A for ; Tue, 7 Apr 2020 01:38:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8FA742076E for ; Tue, 7 Apr 2020 01:38:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="O1iO/1cI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FA742076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 281ED8E0005; Mon, 6 Apr 2020 21:38:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 232788E0001; Mon, 6 Apr 2020 21:38:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16F878E0005; Mon, 6 Apr 2020 21:38:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id F3E478E0001 for ; Mon, 6 Apr 2020 21:38:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B23408019DD0 for ; Tue, 7 Apr 2020 01:38:57 +0000 (UTC) X-FDA: 76679350314.23.pet45_4e359b4d4b21a X-HE-Tag: pet45_4e359b4d4b21a X-Filterd-Recvd-Size: 3900 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Apr 2020 01:38:57 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id x16so1512824qts.11 for ; Mon, 06 Apr 2020 18:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F0V84GznQIsN+4SGDl5mAomkomdqcxNUXjTt40LJoI8=; b=O1iO/1cIlXZzCWiXB9+N8Z/s/ZDrrhWL5RZHWQNV6RPvFIgdTwhusypEd24N3EvS+u CEtSn9Vu6T6XXI7RFnCoJAJgioCjZCIw9yc5hfy0VkDjmt7fnqeDu29cIJJEx104AlNE DsMfHbHlgUg2CJcBkCG6W2+eH1mxmqyNfhGIc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F0V84GznQIsN+4SGDl5mAomkomdqcxNUXjTt40LJoI8=; b=HPl9PhA2dA1xCsZfd85iS37eEvGuAYH1XL5YWi+RlojWfihZZuT0s2rvMmS2dx1/R0 WXvaYsOCns8kAZMrMBns32hXd/ilUF0nemelSNCfl6Xk5S/XMKFXOHHJiTgPfC5yLEsr ZbD6KWDfhUh/8KhAur5W3FM478CX0wnw139TWBEP6F2WLPlWEGJNLW6fakBoJKCmnHCC tlGjgzCvvhWE/+Xq4HVmvfGNejRGmLfNaTs9a4BTTWFkHkhTDvVlczqomA/8hkY/Q6aK lH5Qzp+Kad90rHNvqs2ajdOXa740qFTKWerbLPkIFcC/31kFks2rqj8AmDgS65p7rx+n QQFg== X-Gm-Message-State: AGi0PuYakqm7Id+MzsKhuBd3vmoI/BYZGxQIPjhwFJGZL/l8aFuBp4vC e/RPDmsKk9x4DkMLCVRP8QpGhG4RAFs= X-Google-Smtp-Source: APiQypJQIpzp8PWp6QS6VwafE9svAdjf9Tl0lNf3REDNclWpyq8GBv9wM3bcDa2wbyix6/gocLEKew== X-Received: by 2002:ac8:2dae:: with SMTP id p43mr113698qta.341.1586223536644; Mon, 06 Apr 2020 18:38:56 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id h63sm10806252qkd.49.2020.04.06.18.38.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2020 18:38:55 -0700 (PDT) Date: Mon, 6 Apr 2020 21:38:55 -0400 From: Joel Fernandes To: David Rientjes Cc: Michal Hocko , Andrew Morton , "Paul E. McKenney" , Neil Brown , linux-mm@kvack.org, LKML , Michal Hocko , "Paul E . McKenney" Subject: Re: [PATCH 2/2] mm: make it clear that gfp reclaim modifiers are valid only for sleepable allocations Message-ID: <20200407013855.GA11326@google.com> References: <20200403083543.11552-1-mhocko@kernel.org> <20200403083543.11552-3-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 03, 2020 at 12:41:51PM -0700, David Rientjes wrote: > On Fri, 3 Apr 2020, Michal Hocko wrote: > > > From: Michal Hocko > > > > While it might be really clear to MM developers that gfp reclaim > > modifiers are applicable only to sleepable allocations (those with > > __GFP_DIRECT_RECLAIM) it seems that actual users of the API are not > > always sure. Make it explicit that they are not applicable for > > GFP_NOWAIT or GFP_ATOMIC allocations which are the most commonly used > > non-sleepable allocation masks. > > > > Acked-by: Paul E. McKenney > > Signed-off-by: Michal Hocko > > Acked-by: David Rientjes Reviewed-by: Joel Fernandes (Google) thanks, - Joel