From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45F5BC2BB1D for ; Thu, 9 Apr 2020 06:09:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E0CB520784 for ; Thu, 9 Apr 2020 06:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E0CB520784 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 928898E000D; Thu, 9 Apr 2020 02:09:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B27F8E0006; Thu, 9 Apr 2020 02:09:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C8008E000D; Thu, 9 Apr 2020 02:09:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 6D5968E0006 for ; Thu, 9 Apr 2020 02:09:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3E1CA181AEF3E for ; Thu, 9 Apr 2020 06:09:15 +0000 (UTC) X-FDA: 76687289070.03.army71_50bd39ba14406 X-HE-Tag: army71_50bd39ba14406 X-Filterd-Recvd-Size: 1401 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Apr 2020 06:09:14 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2C1FD68C4E; Thu, 9 Apr 2020 08:09:12 +0200 (CEST) Date: Thu, 9 Apr 2020 08:09:11 +0200 From: Christoph Hellwig To: Hillf Danton Cc: Christoph Hellwig , Andrew Morton , linux-mm@kvack.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 25/28] mm: remove vmalloc_user_node_flags Message-ID: <20200409060911.GA30101@lst.de> References: <20200408115926.1467567-1-hch@lst.de> <20200409040645.14400-1-hdanton@sina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200409040645.14400-1-hdanton@sina.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000173, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 09, 2020 at 12:06:45PM +0800, Hillf Danton wrote: > > - const gfp_t flags = __GFP_NOWARN | __GFP_ZERO; > > + const gfp_t gfp = __GFP_NOWARN | __GFP_ZERO; > > + > > + return __vmalloc_node_range(size, align, VMALLOC_START, VMALLOC_END, > > + gfp | GFP_KERNEL | __GFP_RETRY_MAYFAIL, PAGE_KERNEL, > > Dunno if __GFP_ZERO needs to be added to match the current > vmalloc_user_node_flags(). __GFP_ZERO is already included in "gfp".