From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B65AC2BB86 for ; Mon, 13 Apr 2020 10:05:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DFA5C206E9 for ; Mon, 13 Apr 2020 10:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFA5C206E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A7458E0001; Mon, 13 Apr 2020 06:04:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ECFDF8E00FB; Mon, 13 Apr 2020 06:04:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06288E0001; Mon, 13 Apr 2020 06:04:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 9A84F8E00F8 for ; Mon, 13 Apr 2020 06:04:56 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4B8BD181AEF0B for ; Mon, 13 Apr 2020 10:04:56 +0000 (UTC) X-FDA: 76702398192.06.ocean99_2b07616dc1e33 X-HE-Tag: ocean99_2b07616dc1e33 X-Filterd-Recvd-Size: 2603 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 10:04:55 +0000 (UTC) IronPort-SDR: igQMbUhpCHyY3PWbFJOuixJ6EwGLSC9aIt3DeH1rlowWSNLkDA7jk0DSG/NMzbi3p1jhuY7nNl b39qowEfHX2w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2020 03:04:53 -0700 IronPort-SDR: 3mWnaOO+JmTSCPuCTOnFOfK1CGZY/AlNXPoIlCr28ClP3WBwQVVzwkoWA3tPapr9JTw5De68rV h/wVa3xF/QmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,378,1580803200"; d="scan'208";a="243499890" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 13 Apr 2020 03:04:51 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 8D698E1; Mon, 13 Apr 2020 13:04:50 +0300 (EEST) From: "Kirill A. Shutemov" To: akpm@linux-foundation.org, Andrea Arcangeli Cc: Zi Yan , Yang Shi , Ralph Campbell , John Hubbard , William Kucharski , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Subject: [PATCH 3/6] khugepaged: Drain all LRU caches before scanning pages Date: Mon, 13 Apr 2020 13:04:44 +0300 Message-Id: <20200413100447.20073-4-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200413100447.20073-1-kirill.shutemov@linux.intel.com> References: <20200413100447.20073-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Having a page in LRU add cache offsets page refcount and gives false-negative on PageLRU(). It reduces collapse success rate. Drain all LRU add caches before scanning. It happens relatively rare and should not disturb the system too much. Signed-off-by: Kirill A. Shutemov --- mm/khugepaged.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 5968ec5ddd6b..ee66c140c2d6 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2059,6 +2059,8 @@ static void khugepaged_do_scan(void) =20 barrier(); /* write khugepaged_pages_to_scan to local stack */ =20 + lru_add_drain_all(); + while (progress < pages) { if (!khugepaged_prealloc_page(&hpage, &wait)) break; --=20 2.26.0