From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4743CC2BA19 for ; Mon, 13 Apr 2020 13:41:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 08B722073E for ; Mon, 13 Apr 2020 13:41:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AS59FWW5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08B722073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91A3E8E0119; Mon, 13 Apr 2020 09:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB528E0104; Mon, 13 Apr 2020 09:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BA428E0119; Mon, 13 Apr 2020 09:41:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 66E3E8E0104 for ; Mon, 13 Apr 2020 09:41:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 354ED3489 for ; Mon, 13 Apr 2020 13:41:09 +0000 (UTC) X-FDA: 76702943058.24.wave62_271f5b6393f10 X-HE-Tag: wave62_271f5b6393f10 X-Filterd-Recvd-Size: 2495 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Mon, 13 Apr 2020 13:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PXr19U1fgLFA690aiYcKrrCMpq73umlTXiDnSKGqGOU=; b=AS59FWW5J2xkZJ9kAYmjKnECFC BLSjvKBPwhifmVm0b5v4PfawQRVu5DP0tQGTKPn6KCVJMt7KdvBxQpzRQnHyk4LAWKvUfkYN+RLcV n/pjOAShKf8BL2G3umFK2CB5KD4whLLIBC3Tw8s+tBTw8ia9togBAWZhVArgb67NY36Lsv3wSNc7H PwUWigJp4ffAivNapErEQqgf9qRfC0XGFRp5sSkQkw0J0y3Ou64R3DRZ3kgJuUanyLiHXv6t9uvpB RYquPuIThmO9pQiFXNaeVJAe5rkXt9G2Xe8fCsiX0tRh/cMK+w3C4nXGQ+lewhZRyZBD7oybQW222 Mtlbo1Hg==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNzKk-0001yI-VC; Mon, 13 Apr 2020 13:41:06 +0000 Date: Mon, 13 Apr 2020 06:41:06 -0700 From: Matthew Wilcox To: Nicholas Piggin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v2 4/4] mm/vmalloc: Hugepage vmalloc mappings Message-ID: <20200413134106.GN21484@bombadil.infradead.org> References: <20200413125303.423864-1-npiggin@gmail.com> <20200413125303.423864-5-npiggin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200413125303.423864-5-npiggin@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 13, 2020 at 10:53:03PM +1000, Nicholas Piggin wrote: > +static int vmap_pages_range_noflush(unsigned long start, unsigned long end, > + pgprot_t prot, struct page **pages, > + unsigned int page_shift) > +{ > + if (page_shift == PAGE_SIZE) { ... I think you meant 'page_shift == PAGE_SHIFT' Overall I like this series, although it's a bit biased towards CPUs which have page sizes which match PMD/PUD sizes. It doesn't offer the possibility of using 64kB page sizes on ARM, for example. But it's a step in the right direction.