Re: [PATCH v2 3/4] mm: HUGE_VMAP arch query functions cleanup

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3315 bytes --]

Hi Nicholas,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on powerpc/next tip/x86/mm linus/master v5.7-rc1 next-20200413]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Nicholas-Piggin/huge-vmalloc-mappings/20200414-031028
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/asm-generic/io.h:887:0,
                    from arch/x86/include/asm/io.h:375,
                    from arch/x86/include/asm/dma.h:13,
                    from include/linux/memblock.h:14,
                    from arch/x86/mm/ioremap.c:10:
   include/linux/vmalloc.h:94:44: error: unknown type name 'prprot_t'; did you mean 'pgprot_t'?
    static inline bool arch_vmap_pmd_supported(prprot_t prot) { return false; }
                                               ^~~~~~~~
                                               pgprot_t
>> arch/x86/mm/ioremap.c:463:6: error: redefinition of 'arch_vmap_p4d_supported'
    bool arch_vmap_p4d_supported(pgprot_t prot)
         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/asm-generic/io.h:887:0,
                    from arch/x86/include/asm/io.h:375,
                    from arch/x86/include/asm/dma.h:13,
                    from include/linux/memblock.h:14,
                    from arch/x86/mm/ioremap.c:10:
   include/linux/vmalloc.h:92:20: note: previous definition of 'arch_vmap_p4d_supported' was here
    static inline bool arch_vmap_p4d_supported(pgprot_t prot) { return false; }
                       ^~~~~~~~~~~~~~~~~~~~~~~
>> arch/x86/mm/ioremap.c:468:6: error: redefinition of 'arch_vmap_pud_supported'
    bool arch_vmap_pud_supported(pgprot_t prot)
         ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/asm-generic/io.h:887:0,
                    from arch/x86/include/asm/io.h:375,
                    from arch/x86/include/asm/dma.h:13,
                    from include/linux/memblock.h:14,
                    from arch/x86/mm/ioremap.c:10:
   include/linux/vmalloc.h:93:20: note: previous definition of 'arch_vmap_pud_supported' was here
    static inline bool arch_vmap_pud_supported(pgprot_t prot) { return false; }
                       ^~~~~~~~~~~~~~~~~~~~~~~

vim +/arch_vmap_p4d_supported +463 arch/x86/mm/ioremap.c

   462	
 > 463	bool arch_vmap_p4d_supported(pgprot_t prot)
   464	{
   465		return 0;
   466	}
   467	
 > 468	bool arch_vmap_pud_supported(pgprot_t prot)
   469	{
   470	#ifdef CONFIG_X86_64
   471		return boot_cpu_has(X86_FEATURE_GBPAGES);
   472	#else
   473		return 0;
   474	#endif
   475	}
   476	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7255 bytes --]