linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: 1587089010-110083-1-git-send-email-bernard@vivo.com
Cc: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	opensource.kernel@vivo.com, Bernard Zhao <bernard@vivo.com>
Subject: Re: [PATCH V2] kmalloc_index optimization(code size & runtime stable)
Date: Tue, 21 Apr 2020 04:18:49 -0700	[thread overview]
Message-ID: <20200421111849.GL5820@bombadil.infradead.org> (raw)
In-Reply-To: <20200421032501.127370-1-bernard@vivo.com>

On Mon, Apr 20, 2020 at 08:25:01PM -0700, Bernard Zhao wrote:
> kmalloc_index inline function code size optimization and runtime
> performance stability optimization. After optimization, the function
> kmalloc_index is more stable, the size will never affecte the function`s
> execution efficiency.

Please stop posting this patch until it's faster *for small sizes*.
As I explained last time you posted it, it's not an optimisation.

>             size        time/Per 100 million times
>                         old fun		new fun with optimise
> 		8	203777		241934
> 		16	245611		409278
> 		32	236384		408419
> 		64	275499		447732
> 		128	354909		416439

^^^^ these are the important cases that need to be fast.



  reply	other threads:[~2020-04-21 11:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  3:25 [PATCH V2] kmalloc_index optimization(code size & runtime stable) Bernard Zhao
2020-04-21 11:18 ` Matthew Wilcox [this message]
2020-04-21 11:55   ` 赵军奎
2020-04-21 14:36     ` Matthew Wilcox
2020-04-22  1:12       ` 赵军奎
2020-04-21 13:13 ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200421111849.GL5820@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=1587089010-110083-1-git-send-email-bernard@vivo.com \
    --cc=akpm@linux-foundation.org \
    --cc=bernard@vivo.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=opensource.kernel@vivo.com \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).