From: kbuild test robot <lkp@intel.com>
To: Michel Lespinasse <walken@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Laurent Dufour <ldufour@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Matthew Wilcox <willy@infradead.org>,
Liam Howlett <Liam.Howlett@oracle.com>,
Jerome Glisse <jglisse@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v4 10/10] mmap locking API: rename mmap_sem to mmap_lock
Date: Tue, 21 Apr 2020 13:33:00 +0800 [thread overview]
Message-ID: <202004211357.utKPLP8t%lkp@intel.com> (raw)
In-Reply-To: <20200415004353.130248-11-walken@google.com>
[-- Attachment #1: Type: text/plain, Size: 3665 bytes --]
Hi Michel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on rdma/for-next]
[also build test ERROR on kvms390/next linus/master v5.7-rc2]
[cannot apply to powerpc/next uml/linux-next next-20200420]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Michel-Lespinasse/Add-a-new-mmap-locking-API-wrapping-mmap_sem-calls/20200415-084649
base: https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git for-next
config: riscv-randconfig-a001-20200421 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/riscv/mm/pageattr.c: In function '__set_memory':
>> arch/riscv/mm/pageattr.c:120:21: error: 'struct mm_struct' has no member named 'mmap_sem'; did you mean 'mmap_base'?
120 | down_read(&init_mm.mmap_sem);
| ^~~~~~~~
| mmap_base
arch/riscv/mm/pageattr.c:123:19: error: 'struct mm_struct' has no member named 'mmap_sem'; did you mean 'mmap_base'?
123 | up_read(&init_mm.mmap_sem);
| ^~~~~~~~
| mmap_base
vim +120 arch/riscv/mm/pageattr.c
d3ab332a502123 Zong Li 2020-03-10 105
d3ab332a502123 Zong Li 2020-03-10 106 static int __set_memory(unsigned long addr, int numpages, pgprot_t set_mask,
d3ab332a502123 Zong Li 2020-03-10 107 pgprot_t clear_mask)
d3ab332a502123 Zong Li 2020-03-10 108 {
d3ab332a502123 Zong Li 2020-03-10 109 int ret;
d3ab332a502123 Zong Li 2020-03-10 110 unsigned long start = addr;
d3ab332a502123 Zong Li 2020-03-10 111 unsigned long end = start + PAGE_SIZE * numpages;
d3ab332a502123 Zong Li 2020-03-10 112 struct pageattr_masks masks = {
d3ab332a502123 Zong Li 2020-03-10 113 .set_mask = set_mask,
d3ab332a502123 Zong Li 2020-03-10 114 .clear_mask = clear_mask
d3ab332a502123 Zong Li 2020-03-10 115 };
d3ab332a502123 Zong Li 2020-03-10 116
d3ab332a502123 Zong Li 2020-03-10 117 if (!numpages)
d3ab332a502123 Zong Li 2020-03-10 118 return 0;
d3ab332a502123 Zong Li 2020-03-10 119
d3ab332a502123 Zong Li 2020-03-10 @120 down_read(&init_mm.mmap_sem);
d3ab332a502123 Zong Li 2020-03-10 121 ret = walk_page_range_novma(&init_mm, start, end, &pageattr_ops, NULL,
d3ab332a502123 Zong Li 2020-03-10 122 &masks);
d3ab332a502123 Zong Li 2020-03-10 123 up_read(&init_mm.mmap_sem);
d3ab332a502123 Zong Li 2020-03-10 124
d3ab332a502123 Zong Li 2020-03-10 125 flush_tlb_kernel_range(start, end);
d3ab332a502123 Zong Li 2020-03-10 126
d3ab332a502123 Zong Li 2020-03-10 127 return ret;
d3ab332a502123 Zong Li 2020-03-10 128 }
d3ab332a502123 Zong Li 2020-03-10 129
:::::: The code at line 120 was first introduced by commit
:::::: d3ab332a5021235a74fd832a49c6a99404920d88 riscv: add ARCH_HAS_SET_MEMORY support
:::::: TO: Zong Li <zong.li@sifive.com>
:::::: CC: Palmer Dabbelt <palmerdabbelt@google.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27745 bytes --]
next prev parent reply other threads:[~2020-04-21 5:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:43 [PATCH v4 00/10] Add a new mmap locking API wrapping mmap_sem calls Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 01/10] mmap locking API: initial implementation as rwsem wrappers Michel Lespinasse
2020-04-20 19:48 ` Davidlohr Bueso
2020-04-21 0:48 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 02/10] MMU notifier: use the new mmap locking API Michel Lespinasse
2020-04-20 19:51 ` Davidlohr Bueso
2020-04-15 0:43 ` [PATCH v4 03/10] DMA reservations: " Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 04/10] mmap locking API: use coccinelle to convert mmap_sem rwsem call sites Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 05/10] mmap locking API: convert mmap_sem call sites missed by coccinelle Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 06/10] mmap locking API: convert nested write lock sites Michel Lespinasse
2020-04-20 18:19 ` Daniel Jordan
2020-04-20 19:33 ` Matthew Wilcox
2020-04-21 0:51 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 07/10] mmap locking API: add mmap_read_trylock_non_owner() Michel Lespinasse
2020-04-20 18:22 ` Daniel Jordan
2020-04-20 19:23 ` Matthew Wilcox
2020-04-21 0:55 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 08/10] mmap locking API: add MMAP_LOCK_INITIALIZER Michel Lespinasse
2020-04-20 18:23 ` Daniel Jordan
2020-04-20 19:28 ` Matthew Wilcox
2020-04-21 0:57 ` Michel Lespinasse
2020-04-15 0:43 ` [PATCH v4 09/10] mmap locking API: use lockdep_assert_held Michel Lespinasse
2020-04-21 2:35 ` Matthew Wilcox
2020-04-15 0:43 ` [PATCH v4 10/10] mmap locking API: rename mmap_sem to mmap_lock Michel Lespinasse
2020-04-20 18:28 ` Daniel Jordan
2020-04-21 5:33 ` kbuild test robot [this message]
2020-04-21 22:19 ` Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202004211357.utKPLP8t%lkp@intel.com \
--to=lkp@intel.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=jglisse@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).