From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75537C55181 for ; Wed, 22 Apr 2020 06:37:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3754C20747 for ; Wed, 22 Apr 2020 06:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VLLZvjTy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3754C20747 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DE22D8E0006; Wed, 22 Apr 2020 02:37:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB9638E0003; Wed, 22 Apr 2020 02:37:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF72F8E0006; Wed, 22 Apr 2020 02:37:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0144.hostedemail.com [216.40.44.144]) by kanga.kvack.org (Postfix) with ESMTP id B89F68E0003 for ; Wed, 22 Apr 2020 02:37:40 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 721438248047 for ; Wed, 22 Apr 2020 06:37:40 +0000 (UTC) X-FDA: 76734535080.19.room73_42f6e9430f262 X-HE-Tag: room73_42f6e9430f262 X-Filterd-Recvd-Size: 4075 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 06:37:40 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id ay1so562858plb.0 for ; Tue, 21 Apr 2020 23:37:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=M3V1L8dUG+LHRmYCPUTMgmjn7UaZHh+VkReKQj/vaHo=; b=VLLZvjTyPjUgrOmfVUzEK98z+a3DuIJzk8YklsxG4duu/ZaQG/OxRt8VGQQoJk5rSq w7PDHAUR5t3p6G6E5k1yyL2g/BJnmWDAzsogEl/KU5MclGkgNEPL4u+ymQ9CzV86Qwsy 0DVS6CS9PA+EgKfrysJ1Pol0cTsJA5+L+3fv7IzvAL6fh+PoJ5JNVu+S5fnmoOHeQWDX TAZTS4f/IqI97thaP3pnigLg89b/Gvu1vz/7gT1qkKSgpX1SMizwilKhgqrKOYye0583 aM9l8fc9I5Wdv0p0yXEAD0AxRoj9ohgIbIzLiNGTYouJqv4OA1f8sX7e9qzwcHgN+PWS 17bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=M3V1L8dUG+LHRmYCPUTMgmjn7UaZHh+VkReKQj/vaHo=; b=lvOr6p+nuergxY8i/CkyLjJeZmjI86u5qADDuvGEqcCvC9qrOVDnSBZdI2W3woRtDg 8zA7AZpMNZNi36elW7dKD1jDTzdb+WBm756x9m6eykxHQ/qE/fLBTZ4OZ8PiYGET3U3+ LePzwOYVQFxOVW7JuiWgnc3yo54McFamrtgaLqXVsJ1nEQsR389XdqNderijwyoyfOIH uU9eO3UjQwcTHcpigDpg8d1704MPZUZ0TNnpma2IAY1Kl6b5fBsUTJyu7jVoF6SLdiRH cXttADYY5WkvLz6TI3XTWUQHKkfc6jtp4Ov88yTxjbu6F2hQf3/i1IOWIthWq+uuYy2U B15w== X-Gm-Message-State: AGi0PuZYEmx6mDnJOL+1n9IB9aBNt39CSRYlGxauBt5XVq4ROE30BkHs F1sf2uuv4mtkuaAX+kF54Kc= X-Google-Smtp-Source: APiQypJPHB6y2FOy7ihkfqvwyGsoDRZ9hscuVvE02808VtIGkZYuLBvWbO5B9VdXZnS6hGVW6chmBA== X-Received: by 2002:a17:902:d693:: with SMTP id v19mr26122013ply.9.1587537459292; Tue, 21 Apr 2020 23:37:39 -0700 (PDT) Received: from js1304-desktop ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id n17sm4387026pff.81.2020.04.21.23.37.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Apr 2020 23:37:38 -0700 (PDT) Date: Wed, 22 Apr 2020 15:37:33 +0900 From: Joonsoo Kim To: Johannes Weiner Cc: Alex Shi , Shakeel Butt , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 04/18] mm: memcontrol: move out cgroup swaprate throttling Message-ID: <20200422063732.GD6780@js1304-desktop> References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-5-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420221126.341272-5-hannes@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 06:11:12PM -0400, Johannes Weiner wrote: > The cgroup swaprate throttling is about matching new anon allocations > to the rate of available IO when that is being throttled. It's the io > controller hooking into the VM, rather than a memory controller thing. > > Rename mem_cgroup_throttle_swaprate() to cgroup_throttle_swaprate(), > and drop the @memcg argument which is only used to check whether the > preceding page charge has succeeded and the fault is proceeding. > > We could decouple the call from mem_cgroup_try_charge() here as well, > but that would cause unnecessary churn: the following patches convert > all callsites to a new charge API and we'll decouple as we go along. > > Signed-off-by: Johannes Weiner Reviewed-by: Joonsoo Kim