From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4357C54FCB for ; Wed, 22 Apr 2020 17:24:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7AF332082E for ; Wed, 22 Apr 2020 17:24:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF332082E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2AE7F8E000A; Wed, 22 Apr 2020 13:24:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25F138E0003; Wed, 22 Apr 2020 13:24:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19B768E000A; Wed, 22 Apr 2020 13:24:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 00B118E0003 for ; Wed, 22 Apr 2020 13:24:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 9DCE6181AEF09 for ; Wed, 22 Apr 2020 17:24:34 +0000 (UTC) X-FDA: 76736165268.15.wind76_27e3f3f566362 X-HE-Tag: wind76_27e3f3f566362 X-Filterd-Recvd-Size: 2137 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 17:24:33 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id CA5C468CEC; Wed, 22 Apr 2020 19:24:31 +0200 (CEST) Date: Wed, 22 Apr 2020 19:24:31 +0200 From: Christoph Hellwig To: Vlastimil Babka Cc: Christoph Hellwig , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Andrew Morton Subject: Re: [PATCH 3/5] sysctl: remove all extern declaration from sysctl.c Message-ID: <20200422172431.GB30102@lst.de> References: <20200421171539.288622-1-hch@lst.de> <20200421171539.288622-4-hch@lst.de> <13b10b87-6753-7e7c-fa56-20d7793250d6@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13b10b87-6753-7e7c-fa56-20d7793250d6@suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 22, 2020 at 12:30:22PM +0200, Vlastimil Babka wrote: > On 4/21/20 7:15 PM, Christoph Hellwig wrote: > > Extern declarations in .c files are a bad style and can lead to > > mismatches. Use existing definitions in headers where they exist, > > and otherwise move the external declarations to suitable header > > files. > > Your cleanup reminds me of this Andrew's sigh from last week [1]. > I'm not saying your series should do that too, just wondering if some of the > moves you are doing now would be better suited for the hypothetical new header > to avoid moving them again later (but I admit I haven't looked closer). > > [1] > https://lore.kernel.org/linux-api/20200417174654.9af0c51afb5d9e35e5519113@linux-foundation.org/ I thought of that, but I'm not really sure it is worth it. I'd rather move more sysctl implementations out of sysctl.c and just export the tables back to it.