From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3526EC55185 for ; Wed, 22 Apr 2020 23:03:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3E2C20776 for ; Wed, 22 Apr 2020 23:03:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="oZ6I3DZ+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3E2C20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=joelfernandes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8DB748E0006; Wed, 22 Apr 2020 19:03:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88B8D8E0003; Wed, 22 Apr 2020 19:03:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1168E0006; Wed, 22 Apr 2020 19:03:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 5F7938E0003 for ; Wed, 22 Apr 2020 19:03:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0DF90180AD81D for ; Wed, 22 Apr 2020 23:03:25 +0000 (UTC) X-FDA: 76737019170.07.cloud46_57fbf5cb8a360 X-HE-Tag: cloud46_57fbf5cb8a360 X-Filterd-Recvd-Size: 4625 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 23:03:24 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id h6so1894768qvz.8 for ; Wed, 22 Apr 2020 16:03:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q+ZUmGFleIQNVOFy8fFchFqrYnQYIl2Kzm4X0Ut4dcY=; b=oZ6I3DZ+oVw9DiS9NwH9ubCLOmCZjMFu1LmScEI32LKMmsrmV8ERXRrqSIdw2wctfi /sduzA/W/yc2gYcBwwRDVv40zmcI4Z45eG+c3sfRB/CFQxip2mHDO/dj7oQ7CDgm/sXm d+18N/vsSc0iLhx+gvnDebageo5+ke+0dGWas= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q+ZUmGFleIQNVOFy8fFchFqrYnQYIl2Kzm4X0Ut4dcY=; b=tw6SJrxlzDDCIA3zwPAe7GrciefG56SJ+roLOrm4tyaE9tHoetMkIYZmqThHJiWMH9 djbfrBC8BSJYUmEW1i790wFp+1oCdudX97ZvYVZqC07P7SNQebZ+YhFqrzjcrlpUcJtH vlHwHu5tHkyCwYKwngySVcKaaQ0X89zBgoypy4EPIVKBFzEjy410woVoAKB728vmWcyJ EMrfN1F67ogPoIYe0XHi7afztKU6AKckE4Pryzc2wXqBO2DKTvXXjJ5HdexaEtWswXoj 5Cmku3CztyemsQZ1BQcb9nu+9gM8MI/W8i4TBEzVPKqYmq3UaUw3uHFgKiCg617XqxXK Y92g== X-Gm-Message-State: AGi0PuYCtICudUcrzCLhlHOvAcpVeYx0tJFCF6cWqpZDrEs9BPGyL/vt Dl7xhkF8+iFADvQDZV7lWebDdg== X-Google-Smtp-Source: APiQypLG48pUEwzbOklpqni6odRxIsyj2/KAASfEwNNej9pTvyYVGnFgJ4r2rHVRVvuHh0XP9YEo0w== X-Received: by 2002:a0c:9e6d:: with SMTP id z45mr1420079qve.206.1587596603750; Wed, 22 Apr 2020 16:03:23 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id g133sm400658qke.73.2020.04.22.16.03.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2020 16:03:23 -0700 (PDT) Date: Wed, 22 Apr 2020 19:03:22 -0400 From: Joel Fernandes To: Uladzislau Rezki Cc: Andrew Morton , LKML , "Paul E . McKenney" , RCU , Steven Rostedt , Oleksiy Avramchenko , linux-mm@kvack.org Subject: Re: [PATCH v1 5/6] rcu: rename kfree_call_rcu()/__kfree_rcu() Message-ID: <20200422230322.GA100393@google.com> References: <20200315181840.6966-1-urezki@gmail.com> <20200315181840.6966-6-urezki@gmail.com> <20200316152541.GD190951@google.com> <20200316190144.GB10577@pc636> <20200420201527.679247f6fa76cba4331f3cd3@linux-foundation.org> <20200421120358.GA5117@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200421120358.GA5117@pc636> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 21, 2020 at 02:03:58PM +0200, Uladzislau Rezki wrote: > Hello, Andrew. > > > > > I based the kfree_rcu shrinker patches on an 'rcu/kfree' branch in my git > > > > tree: https://github.com/joelagnel/linux-kernel/tree/rcu/kfree > > > > > > > > For now I manually applied 5/6. All others applied cleanly. > > > > > > > > Updated the tree as I continue to review your patches. > > > > > > > > I'm not sure what's happening here - these patches aren't yet in > > linux-next. > > > Please have a look here, i explained in detail in my cover latter > what we would like to achieve: https://lkml.org/lkml/2020/3/23/242 > > > A couple of thoughts: > > > > - Please cc linux-mm@kvack.org on this patchset and anything else > > which impacts MM. > > > OK. I thought that is related to RCU, therefore i did not want to > spam, but i included you :) Next time we will keep linux-mm@kvack.org > in a loop. Sorry for that. Sorry from my side as well. Will keep linux-mm in the loop henceforth. thanks, - Joel > > > > > - It's a bit strange to create new infrastructure which has but a > > single call site. Please tell us much more about "there was also > > request/interest so there will be new comers" to set minds at ease. > > > > Who/where are these possible new callsites and when can we expect to > > see that code? > > > https://lkml.org/lkml/2020/3/23/242 here i wrote motivation. Please > check it. If you have some questions please ask. > > -- > Vlad Rezki