From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F51CC2BA19 for ; Fri, 24 Apr 2020 00:30:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24B072071E for ; Fri, 24 Apr 2020 00:30:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m89Egqb1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24B072071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACC328E0006; Thu, 23 Apr 2020 20:30:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7CAA8E0003; Thu, 23 Apr 2020 20:30:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 96A7D8E0006; Thu, 23 Apr 2020 20:30:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0097.hostedemail.com [216.40.44.97]) by kanga.kvack.org (Postfix) with ESMTP id 73CAA8E0003 for ; Thu, 23 Apr 2020 20:30:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 381E88248047 for ; Fri, 24 Apr 2020 00:30:01 +0000 (UTC) X-FDA: 76740866202.19.heart66_1d3d9f7733e42 X-HE-Tag: heart66_1d3d9f7733e42 X-Filterd-Recvd-Size: 3924 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Apr 2020 00:30:00 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id d24so3087010pll.8 for ; Thu, 23 Apr 2020 17:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VKBqm9dD1eT/9SukXzSTV56tiVVlcyEzdR7J/pmXPKk=; b=m89Egqb1/fpd9kMAnDYFVXpT/PykNFJynjooI9IkfNzptBO0nn6hRNuNFqW+S9/cQs I2G7BCUXvItMqimgVATxYqv+RILMmTTE4djYombXNLu7Z7n0bl+CqXPnvz16U6EO34Wm Cl2DFf5an4Lcfssj4J58eZqy/CAEkTbf154kGv5vfvMg/Ja8TA+7tat/vCLcw43k8XfA DepdD4VhfU78IPl278F8nFbHfOZ1CVrF/InsmkhRejTmrYOorm+sADgK48QqPxeygD27 7nQGN83N0yfvNd32LTvpnEtyHVNpEDdIg/dI0uCv/eAo+I6Q5DjtOMEeNrU755zx2Olf j1bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VKBqm9dD1eT/9SukXzSTV56tiVVlcyEzdR7J/pmXPKk=; b=P9x9of955CBNKyQOUAB518rFpyWbxI15zaDwpo3KgRdnHtr8hX1XdBaof0QNN2P24Z DAse4cPA+ND5vEyAouc4p7CP2sm+ksNghF21iMRQRWr1pmTL0o5gtF26yYrFsF656Ewq BDB2yQSLen0GWYNFrFkJNdnJ7IHmHygbHDN8U0h2F2RZ1twkYHMbGgyLrT7x+XQpJpbr eJGkvtaFvt+kWduHbZXWpT8Zcm0jOGND0QjXWRSS4j9rulH5lk+NlJRGjbTL+2wvUwQO 1/TJl2o0SZF8CnasT4oS0006vV/QX49doafL5adPn2lBy7UDk2z2JdPnbhjB/xh5ot0P 9y0A== X-Gm-Message-State: AGi0PubfH57+FMi7hiuxNRKPPNHNO3EJsJHJ5si+O2/haqpS3OfII+5p zKKZVxCrcyX/8uTkE9NoVlI= X-Google-Smtp-Source: APiQypJT6Nadt5BNvAzYM+MkUKF7U+h/3uJB33B3PTb7LycB291fgvl92BjVgBvk/S9NyKHI021hmA== X-Received: by 2002:a17:902:8bca:: with SMTP id r10mr6200279plo.225.1587688199726; Thu, 23 Apr 2020 17:29:59 -0700 (PDT) Received: from js1304-desktop ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id a136sm3891498pfa.99.2020.04.23.17.29.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Apr 2020 17:29:59 -0700 (PDT) Date: Fri, 24 Apr 2020 09:29:54 +0900 From: Joonsoo Kim To: Johannes Weiner Cc: Alex Shi , Shakeel Butt , Hugh Dickins , Michal Hocko , "Kirill A. Shutemov" , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 12/18] mm: memcontrol: convert anon and file-thp to new mem_cgroup_charge() API Message-ID: <20200424002953.GB13929@js1304-desktop> References: <20200420221126.341272-1-hannes@cmpxchg.org> <20200420221126.341272-13-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200420221126.341272-13-hannes@cmpxchg.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 20, 2020 at 06:11:20PM -0400, Johannes Weiner wrote: > With the page->mapping requirement gone from memcg, we can charge anon > and file-thp pages in one single step, right after they're allocated. > > This removes two out of three API calls - especially the tricky commit > step that needed to happen at just the right time between when the > page is "set up" and when it's "published" - somewhat vague and fluid > concepts that varied by page type. All we need is a freshly allocated > page and a memcg context to charge. > > Signed-off-by: Johannes Weiner Reviewed-by: Joonsoo Kim