From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11478C54FD0 for ; Fri, 24 Apr 2020 14:53:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA4492071E for ; Fri, 24 Apr 2020 14:53:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mPEZtBjN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA4492071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D2D98E0005; Fri, 24 Apr 2020 10:53:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9888E0003; Fri, 24 Apr 2020 10:53:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BF7B8E0005; Fri, 24 Apr 2020 10:53:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 3253F8E0003 for ; Fri, 24 Apr 2020 10:53:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id E0D675DF5 for ; Fri, 24 Apr 2020 14:53:16 +0000 (UTC) X-FDA: 76743041592.29.frogs43_91014dfac9d54 X-HE-Tag: frogs43_91014dfac9d54 X-Filterd-Recvd-Size: 7153 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Apr 2020 14:53:16 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id u6so10217961ljl.6 for ; Fri, 24 Apr 2020 07:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:references:mime-version:message-id :content-transfer-encoding; bh=uTtCNz6KSBU2x9uYOHTLElgr2mm8uX/IZ5mBAn5VGkU=; b=mPEZtBjNT1a3JVUcHVdtPbSdGQIUL1RbwAR4YvEIVjHP79DRibplEhUU/ENdyit0GX LU/KghsFOgG10lN5iSQspCvppApWRit2HYANZQ5HIz/tvWFVpT+AS+AhZteHS9QtI402 mNRIgBWq1qNEK1p+w7Yj1FrctTfJxgMm2uM6HXJnhqPEJ7A7E1hVFygwDfWyNwDdMnDK I41q046VjMcaokTCRMONxvj6xxTuTP7m2TvmNoLVklk/soBXykhgXTA89MJILmrWGCAh WTsSinHf+FMsuAfGD7H6r2oL+YCW9tfbTb2EQs/ca8yvzrgSbueatE/CmC9gh98nmElH H11w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:references:mime-version :message-id:content-transfer-encoding; bh=uTtCNz6KSBU2x9uYOHTLElgr2mm8uX/IZ5mBAn5VGkU=; b=ECsm1Syu4wl218KXvVuNFiYyOrDSFv5391GmCj0eHLdJjhnaEVDNkW5wz2Fiagi1cZ x8OUzJhN107tjaEEyzzi/l5P+EGi8op06q4g8DQMW2RvU1LHtyPhnY6bPR2uZoev9hWV /FxZ0pXXwH/dIBjvDO05LN4tZsMyH6eq1dc++vfjDMczUBECie9dkLTrpTDNisjJQUvy pyz+W7YuS5pK9Mh+CqNXypWcN543/6Qico+qnoTYzf9YO2v0uEppt5G7qAhIwA264UOF 8X12hImFStFsW3NtDlGf4MMdRAWLDgGga5rysK+lw2w0yT4R7O2Q9SlOBBfVwzjSzVII gm5g== X-Gm-Message-State: AGi0Puauya44ewpYr5m9lbPjEYb2uofBsHIaUklvNrNpr2SMVJRMUwX0 W1iA0Bb41Vx5/7aIqPWOV4w= X-Google-Smtp-Source: APiQypKcz7ZNyhgOSGZcRJ3dEhzMuYPlN5kt7bPHM9uPXzZ2ytxIoWjupTxWDXjZouZuS2MjrDYEDA== X-Received: by 2002:a2e:6a08:: with SMTP id f8mr6493471ljc.8.1587739994512; Fri, 24 Apr 2020 07:53:14 -0700 (PDT) Received: from N-20L6PF1KTYA2 ([131.228.2.20]) by smtp.gmail.com with ESMTPSA id e7sm5276396lfc.72.2020.04.24.07.53.12 (version=TLS1_2 cipher=AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2020 07:53:13 -0700 (PDT) Date: Fri, 24 Apr 2020 22:53:11 +0800 From: "Li Xinhai" To: "Jason Gunthorpe" Cc: "Mike Kravetz" , "linux-mm@kvack.org" , akpm , "Punit Agrawal" , Longpeng Subject: Re: [PATCH] mm/hugetlb: avoid unnecessary check on pud and pmd entry in huge_pte_offset References: <1587646154-26276-1-git-send-email-lixinhai.lxh@gmail.com>, , <20200423183835.GA13640@mellanox.com>, <202004241207494655904@gmail.com>, <20200424125753.GK13640@mellanox.com>, <2020042421333861801820@gmail.com>, <20200424134206.GM13640@mellanox.com>, <2020042422071809487733@gmail.com>, <20200424141021.GG26002@ziepe.ca> X-Priority: 3 X-GUID: 0BC886FB-2D03-4D9B-85EC-0EC23482E101 X-Has-Attach: no X-Mailer: Foxmail 7.2.13.365[cn] Mime-Version: 1.0 Message-ID: <2020042422530695254845@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: T24gMjAyMC0wNC0yNMKgYXQgMjI6MTDCoEphc29uIEd1bnRob3JwZcKgd3JvdGU6Cj5PbiBGcmks IEFwciAyNCwgMjAyMCBhdCAxMDowNzoxOVBNICswODAwLCBMaSBYaW5oYWkgd3JvdGU6Cj4+IE9u IDIwMjAtMDQtMjTCoGF0IDIxOjQywqBKYXNvbiBHdW50aG9ycGXCoHdyb3RlOgo+PiA+T24gRnJp LCBBcHIgMjQsIDIwMjAgYXQgMDk6MzM6NDBQTSArMDgwMCwgTGkgWGluaGFpIHdyb3RlOgo+PiA+ PiA+Cj4+ID4+ID4+ICwgc28gd2hlbiBzeiA9PSBQTURfU0laRSwgcG1kX29mZnNldCgpIG9ubHkg Y2FsbGVkIHdpdGggYSB2YWxpZCBQVUQKPj4gPj4gPj4gZW50cnkgd2hpY2ggcG9pbnQgdG8gUE1E IHBhZ2UgdGFibGUuCj4+ID4+ID4KPj4gPj4gPkJ1dCB3aGF0IHByZXZlbnRzIHB1ZF9odWdlPwo+ PiA+PiA+Cj4+ID4+IGlmIHN6ID09IFBVRF9TSVpFLCB0aGUgJ3JldHVybiAocHRlX3QqKXB1ZCcg YWxyYWR5IGVuZCB0aGUgZnVuY3Rpb24sIHdoaWNoIGNvdmVyCj4+ID4+IHB1ZF9odWdlKCkgYW5k IHB1ZF9ub25lKCksIGJlY2F1c2Ugd2UgdGhlIG1hcHBpbmcgaXMgZm9yIFBVRF9TSVpFIGh1Z2Ug cGFnZS4KPj4gPj4KPj4gPj4gU28sIHRoZXJlIGlzIG5vIHBvc3NpYmlsaXR5IGZvciBwbWRfb2Zm c2V0KCkgYmVlbiBjYWxsZWQgd2l0aCBpbnZhbGlkIHB1ZCBlbnRyeS4KPj4gPj4gQmVsb3cgaXMg dGhlIGNvZGUgSSB1c2VkIGZvciB0ZXN0IHdoaWNoIGhhcyBCVUdfT04sIHRoYXQgc2hvdWxkIGdp dmUgbW9yZQo+PiA+PiBjbGVhciBpZGVhIGFib3V0IHRoZSBzZW1hbnRpY3Mgb2YgY29kZSBwYXRo Ogo+PiA+Pgo+PiA+PiAuLi4KPj4gPj4gcHVkID0gcHVkX29mZnNldChwNGQsIGFkZHIpOwo+PiA+ PiBpZiAoc3ogPT0gUFVEX1NJWkUpIHsKPj4gPj4gLyogbXVzdCBiZSBwdWRfaHVnZSBvciBwdWRf bm9uZSAqLwo+PiA+PiBCVUdfT04oIXB1ZF9odWdlKCpwdWQpICYmICFwdWRfbm9uZSgqcHVkKSk7 Cj4+ID4+IHJldHVybiAocHRlX3QgKilwdWQ7IC8vIG5vdGUgdGhhdCByZXR1cm4gdmFsaWQgcG9p bnRlciBmb3IgcHVkX25vbmUoKSBjYXNlLAo+PiA+PiAvLyBpbnN0ZWFkIG9mIE5VTEwsIHRoYXQg aXMgc2FtZSBzZW1hbnRpY3MgYXMgZXhpc3RpbmcgY29kZS4KPj4gPj4gfQo+PiA+PiBpZiAoIXB1 ZF9wcmVzZW50KCpwdWQpKQo+PiA+PiByZXR1cm4gTlVMTDsgLy8gbm90ZSB0aGF0IG9ubHkgcmV0 dXJuIE5VTEwgaW4gY2FzZSBwdWQgbm90IHByZXNlbnQsCj4+ID4+IC8vIHNhbWUgc2VtYXRpY3Mg YXMgZXhpc3RpbmcgY29kZS4KPj4gPj4gLyogbXVzdCBoYXZlIGEgdmFsaWQgZW50cnkgYW5kIHNp emUgdG8gZ28gZnVydGhlciAqLwo+PiA+PiBCVUdfT04oc3ogIT0gUE1EX1NJWkUpOwo+PiA+Pgo+ PiA+PiBwbWQgPSBwbWRfb2Zmc2V0KHB1ZCwgYWRkcik7Cj4+ID4+IC8qIG11c3QgYmUgcG1kX2h1 Z2Ugb3IgcG1kX25vbmUgKi8KPj4gPj4gQlVHX09OKCFwbWRfaHVnZSgqcG1kKSAmJiAhcG1kX25v bmUoKnBtZCkpOwo+PiA+Cj4+ID5CdXQgd2h5IGlzICFwbWRfaHVnZSgpID8gVGhlIHByaW9yIGNv ZGUgcmV0dXJuZWQgbnVsbCBoZXJlLCBpcyB0aGF0Cj4+ID5kZWFkIGNvZGU/IFlvdXIgY29tbWl0 IG1lc3NhZ2Ugc2hvdWxkIGV4cGxhaW4gYWxsIG9mIHRoaXMuLgo+PiA+Cj4+IGxldCdzIHNlZSBl eGlzaW5nIGNvZGUgZm9yIHBtZCBwYXJ0LCB0aGUgcmVhc29uIGFyZSBpbiBjb21tZW50czoKPj4g Li4uCj4+IMKgIMKgIMKgIMKgIHBtZCA9IHBtZF9vZmZzZXQocHVkLCBhZGRyKTsKPj4gwqAgwqAg wqAgwqAgaWYgKHN6ICE9IFBNRF9TSVpFICYmIHBtZF9ub25lKCpwbWQpKQo+PiDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCByZXR1cm4gTlVMTDsgLy8gZGVhZCBjb2RlLCBtdXN0IHN6ID09IFBNRF9T SVpFCj4+IMKgIMKgIMKgIMKgIC8qIGh1Z2VwYWdlIG9yIHN3YXA/ICovCj4+IMKgIMKgIMKgIMKg IGlmIChwbWRfaHVnZSgqcG1kKSB8fCAhcG1kX3ByZXNlbnQoKnBtZCkpIC8vICFwbWRfcHJlc2Vu dCgpIGFsc28gY292ZXIgcG1kX25vbmUoKSwKPj4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcmV0 dXJuIChwdGVfdCAqKXBtZDsgLy8gc28sIGFsbCBwb3NzaWJsZSBhbmQgdmFsaWQgdmFsdWUgaW4g cG1kIGVudHJ5IHdpbGwgcmVhY2ggaGVyZS4KPj4KPj4gcmV0dXJuIE5VTEw7IC8vIGRlYWQgY29k ZTsgY2FuIHdlIGhhdmUgKCFwbWRfaHVnZSgpICYmIHBtZF9wcmVzZW50KCkpIGFuZCByZWFjaCBo ZXJlP8KgCj4+IC8vIG5vLCBiZWNhdXNlIHRoaXMgaXMgYSBodWdldGxiIG1hcHBpbmcuIG90aGVy d2lzZSwgdGhlcmUgaXMgaW52YWxpZCB2YWx1ZSBpbiBwbWQgZW50cnkuCj4+IC4uLgo+Cj53ZWxs IGlmIHlvdSBhcmUgcmVseWluZyBvbiB0aGUgY2FsbGVyIHRvIG5vdCBjYWxsIHRoaXMgaW4gd3Jv bmcgY2FzZXMKPml0IHdvdWxkIG1ha2Ugc2Vuc2UgdG8gaGF2ZSBhCj4KPmlmIChXQVJOX09OKCFw bWRfaHVnZSgqcG1kKSkpCj7CoMKgwqAgcmV0dXJuIE5VTEwKPgo+VG8gZG9jdW1lbnQgdGhlIGFz c2VydGlvbgo+IApyaWdodCwgaWYgdGhpcyBXQVJOX09OIG9jY3Vycywgd2hpY2ggbWVhbnMgaHVn ZV9wdGVfb2Zmc2V0KCkgYmVlbiBjYWxsZWQKZm9yIGEgbm9ybWFsIDRLIG1hcHBpbmcsIHRoYXQg aXMgYSBidWcgb2YgY2FsbGVyLiBBZnRlciBpbnNwZWN0ZWQgY3VycmVudCBjb2RlCm9mwqBjYWxs ZXJzLMKgbm8gb25lIHRyaWVzIHRvIGNhbGwgaXQgb24gNEsgbWFwcGluZy4KCj5KYXNvbg==