From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <lkp@intel.com>, Christoph Hellwig <hch@lst.de>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [linux-next:master 4466/4894] kernel/bpf/syscall.c:305:58: error: 'VMALLOC_END' undeclared; did you mean 'VM_LOCKED'?
Date: Sun, 26 Apr 2020 09:43:55 +0200 [thread overview]
Message-ID: <20200426074355.GB31501@lst.de> (raw)
In-Reply-To: <20200425170909.dfa87562035f3f9d0abbf417@linux-foundation.org>
On Sat, Apr 25, 2020 at 05:09:09PM -0700, Andrew Morton wrote:
> On Sun, 26 Apr 2020 04:25:54 +0800 kbuild test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 8bdabd09ec86a993419c8c98a4f34c12bc902c6c
> > commit: d4493a599f1aa34153b047da482cf6419f3c79dc [4466/4894] mm: remove vmalloc_user_node_flags
> > config: riscv-randconfig-a001-20200426 (attached as .config)
> > compiler: riscv64-linux-gcc (GCC) 9.3.0
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout d4493a599f1aa34153b047da482cf6419f3c79dc
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv
> >
> > kernel/bpf/syscall.c: In function '__bpf_map_area_alloc':
> > >> kernel/bpf/syscall.c:305:58: error: 'VMALLOC_END' undeclared (first use in this function); did you mean 'VM_LOCKED'?
> > 305 | return __vmalloc_node_range(size, align, VMALLOC_START, VMALLOC_END,
>
> CONFIG_MMU=n.
>
> I guess this will suffice?
It should. But I wonder if BPF actually even has a chance of working
on nommu configs..
>
> --- a/arch/riscv/include/asm/pgtable.h~mm-switch-the-test_vmalloc-module-to-use-__vmalloc_node-fix-fix
> +++ a/arch/riscv/include/asm/pgtable.h
> @@ -472,9 +472,9 @@ static inline int ptep_clear_flush_young
>
> #define PAGE_KERNEL __pgprot(0)
> #define swapper_pg_dir NULL
> +#define TASK_SIZE 0xffffffffUL
> #define VMALLOC_START 0
> -
> -#define TASK_SIZE 0xffffffffUL
> +#define VMALLOC_END TASK_SIZE
>
> #endif /* !CONFIG_MMU */
>
>
> It could be any value, really - we just need VMALLOC_END there to make
> the compiler happy.
---end quoted text---
prev parent reply other threads:[~2020-04-26 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-25 20:25 [linux-next:master 4466/4894] kernel/bpf/syscall.c:305:58: error: 'VMALLOC_END' undeclared; did you mean 'VM_LOCKED'? kbuild test robot
2020-04-26 0:09 ` Andrew Morton
2020-04-26 7:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200426074355.GB31501@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox