From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612B9C5519A for ; Mon, 27 Apr 2020 05:34:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3DE3F2084D for ; Mon, 27 Apr 2020 05:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3DE3F2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A11CD8E0005; Mon, 27 Apr 2020 01:34:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C0EC8E0001; Mon, 27 Apr 2020 01:34:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8AF828E0005; Mon, 27 Apr 2020 01:34:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0214.hostedemail.com [216.40.44.214]) by kanga.kvack.org (Postfix) with ESMTP id 70D588E0001 for ; Mon, 27 Apr 2020 01:34:51 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 2FCCE499604 for ; Mon, 27 Apr 2020 05:34:51 +0000 (UTC) X-FDA: 76752520782.11.vest88_6483820e06f1a X-HE-Tag: vest88_6483820e06f1a X-Filterd-Recvd-Size: 1682 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 05:34:50 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 20B2C68CEE; Mon, 27 Apr 2020 07:34:47 +0200 (CEST) Date: Mon, 27 Apr 2020 07:34:46 +0200 From: Christoph Hellwig To: Andrey Ignatov Cc: Christoph Hellwig , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 5/5] sysctl: pass kernel pointers to ->proc_handler Message-ID: <20200427053446.GA15905@lst.de> References: <20200424064338.538313-1-hch@lst.de> <20200424064338.538313-6-hch@lst.de> <20200424190650.GA72647@rdna-mbp.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200424190650.GA72647@rdna-mbp.dhcp.thefacebook.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 24, 2020 at 12:06:50PM -0700, Andrey Ignatov wrote: > > - > > -#ifdef CONFIG_UCLAMP_TASK > > Decided to skim through the patch one last time to double-check the fix > from previous iteration and found that this ifdef got lost below. > > > -extern int sysctl_sched_uclamp_handler(struct ctl_table *table, int write, > > - void __user *buffer, size_t *lenp, > > - loff_t *ppos); > > -#endif There is no need for ifdefs around prototypes that aren't used.