From: Andrew Morton <akpm@linux-foundation.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/gup.c: Updating the documentation
Date: Mon, 27 Apr 2020 12:26:06 -0700 [thread overview]
Message-ID: <20200427122606.dc29c381f6da47831a40d365@linux-foundation.org> (raw)
In-Reply-To: <1588013630-4497-1-git-send-email-jrdr.linux@gmail.com>
On Tue, 28 Apr 2020 00:23:50 +0530 Souptick Joarder <jrdr.linux@gmail.com> wrote:
> This patch is an attempt to update the documentation.
>
> * Adding / removing extra * based on type of function
> static / global.
I don't think so, unless this is a new kerneldoc convention?
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -722,7 +722,7 @@ static struct page *follow_p4d_mask(struct vm_area_struct *vma,
> return follow_pud_mask(vma, address, p4d, flags, ctx);
> }
>
> -/**
> +/*
> * follow_page_mask - look up a page descriptor from a user-virtual address
> * @vma: vm_area_struct mapping @address
> * @address: virtual address to look up
/** indicates that the comment is in kerneldoc form, not that it has
static scope?
next prev parent reply other threads:[~2020-04-27 19:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 18:53 [PATCH] mm/gup.c: Updating the documentation Souptick Joarder
2020-04-27 19:26 ` Andrew Morton [this message]
2020-04-27 19:31 ` Randy Dunlap
2020-04-28 13:47 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427122606.dc29c381f6da47831a40d365@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).