From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0630C4CECC for ; Mon, 27 Apr 2020 20:50:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A5A8B2074F for ; Mon, 27 Apr 2020 20:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="p0rVVju/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5A8B2074F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3410F8E0005; Mon, 27 Apr 2020 16:50:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1778E0001; Mon, 27 Apr 2020 16:50:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 207E28E0005; Mon, 27 Apr 2020 16:50:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id 054218E0001 for ; Mon, 27 Apr 2020 16:50:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id AC02F8248047 for ; Mon, 27 Apr 2020 20:50:55 +0000 (UTC) X-FDA: 76754829270.26.net23_5f5b9ecf60934 X-HE-Tag: net23_5f5b9ecf60934 X-Filterd-Recvd-Size: 4776 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Apr 2020 20:50:55 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 790922070B; Mon, 27 Apr 2020 20:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588020654; bh=b3YRJyMbKe7izlxJnUJUG6JvHA8qd5m0P2WdjuVvShg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p0rVVju/c1Zvmjo3N8tWUk8YTpm4HfugQ2PagUwbyF8N9miLcZpw7ThT96un3xYH7 LPD1ypHkar7D4beD3Cg36iQfmv7EqFTQBXo/zxHwrfBoB2Ie2OQdef1JQxDKFbxrz7 2S+fn1pY3qWnNxGO+FZXtkPTwcphzXfeXLX0Hrdw= Date: Mon, 27 Apr 2020 13:50:53 -0700 From: Andrew Morton To: Randy Dunlap Cc: broonie@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz, mm-commits@vger.kernel.org, sfr@canb.auug.org.au, Minchan Kim Subject: Re: mmotm 2020-04-26-00-15 uploaded (mm/madvise.c) Message-Id: <20200427135053.a125f84c62e2857e3dcdce4f@linux-foundation.org> In-Reply-To: <39bcdbb6-cac8-aa3b-c543-041f9c28c730@infradead.org> References: <20200426071602.ZmQ_9C0ql%akpm@linux-foundation.org> <39bcdbb6-cac8-aa3b-c543-041f9c28c730@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 26 Apr 2020 15:48:35 -0700 Randy Dunlap w= rote: > On 4/26/20 10:26 AM, Randy Dunlap wrote: > > On 4/26/20 12:16 AM, akpm@linux-foundation.org wrote: > >> The mm-of-the-moment snapshot 2020-04-26-00-15 has been uploaded to > >> > >> http://www.ozlabs.org/~akpm/mmotm/ > >> > >> mmotm-readme.txt says > >> > >> README for mm-of-the-moment: > >> > >> http://www.ozlabs.org/~akpm/mmotm/ > >> > >> This is a snapshot of my -mm patch queue. Uploaded at random hopefu= lly > >> more than once a week. > >> > >> You will need quilt to apply these patches to the latest Linus relea= se (5.x > >> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplica= ted in > >> http://ozlabs.org/~akpm/mmotm/series > >> > >> The file broken-out.tar.gz contains two datestamp files: .DATE and > >> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm= -ss, > >> followed by the base kernel version against which this patch series = is to > >> be applied. > >=20 > > Hi, > > I'm seeing lots of build failures in mm/madvise.c. > >=20 > > Is Minchin's patch only partially applied or is it just missing some = pieces? > >=20 > > a. mm/madvise.c needs to #include > >=20 > > b. looks like the sys_process_madvise() prototype in > > has not been updated: > >=20 > > In file included from ../mm/madvise.c:11:0: > > ../include/linux/syscalls.h:239:18: error: conflicting types for =E2=80= =98sys_process_madvise=E2=80=99 > > asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ > > ^ > > ../include/linux/syscalls.h:225:2: note: in expansion of macro =E2=80= =98__SYSCALL_DEFINEx=E2=80=99 > > __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) > > ^~~~~~~~~~~~~~~~~ > > ../include/linux/syscalls.h:219:36: note: in expansion of macro =E2=80= =98SYSCALL_DEFINEx=E2=80=99 > > #define SYSCALL_DEFINE6(name, ...) SYSCALL_DEFINEx(6, _##name, __VA_= ARGS__) > > ^~~~~~~~~~~~~~~ > > ../mm/madvise.c:1295:1: note: in expansion of macro =E2=80=98SYSCALL_= DEFINE6=E2=80=99 > > SYSCALL_DEFINE6(process_madvise, int, which, pid_t, upid, > > ^~~~~~~~~~~~~~~ > > In file included from ../mm/madvise.c:11:0: > > ../include/linux/syscalls.h:880:17: note: previous declaration of =E2= =80=98sys_process_madvise=E2=80=99 was here > > asmlinkage long sys_process_madvise(int which, pid_t pid, unsigned l= ong start, > > ^~~~~~~~~~~~~~~~~~~ >=20 > I had to add 2 small patches to have clean madvise.c builds: >=20 hm, not sure why these weren't noticed sooner, thanks. This patchset is looking a bit tired now. Things to be addressed (might be out of date): - http://lkml.kernel.org/r/293bcd25-934f-dd57-3314-bbcf00833e51@redhat.co= m - http://lkml.kernel.org/r/2a767d50-4034-da8c-c40c-280e0dda910e@suse.cz (I did this) - http://lkml.kernel.org/r/20200310222008.GB72963@google.com - issues arising from the review of http://lkml.kernel.org/r/20200302193630.68771-8-minchan@kernel.org