From: Waiman Long <longman@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Qian Cai <cai@lca.pw>, Waiman Long <longman@redhat.com>
Subject: [PATCH v2 0/4] mm/slub: Fix sysfs circular locking dependency
Date: Mon, 27 Apr 2020 19:56:17 -0400 [thread overview]
Message-ID: <20200427235621.7823-1-longman@redhat.com> (raw)
v2:
- Use regular cmpxchg() instead of x86-only try_cmpxchg() in patch 2.
- Add patches 3 and 4 to fix circular locking dependency showing up
at shutdown time.
With lockdep enabled, issuing the following command to the slub sysfs
files will cause splat about circular locking dependency to show up
either immediately afterwards or at shutdown time.
# echo 1 > validate
# echo 1 > shrink
This patchset fixes these lockdep splats by replacing slab_mutex with
memcg_cache_ids_sem as well as changing some of the lock operations
with trylock.
Waiman Long (4):
mm, slab: Revert "extend slab/shrink to shrink all memcg caches"
mm/slub: Fix slab_mutex circular locking problem in slab_attr_store()
mm/slub: Fix another circular locking dependency in slab_attr_store()
mm/slub: Fix sysfs shrink circular locking dependency
include/linux/memcontrol.h | 1 +
include/linux/memory_hotplug.h | 2 +
mm/memcontrol.c | 5 ++
mm/memory_hotplug.c | 5 ++
mm/slab.h | 1 -
mm/slab_common.c | 37 -------------
mm/slub.c | 98 +++++++++++++++++++++++++++++-----
7 files changed, 99 insertions(+), 50 deletions(-)
--
2.18.1
next reply other threads:[~2020-04-27 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 23:56 Waiman Long [this message]
2020-04-27 23:56 ` [PATCH v2 1/4] mm, slab: Revert "extend slab/shrink to shrink all memcg caches" Waiman Long
2020-04-27 23:56 ` [PATCH v2 2/4] mm/slub: Fix slab_mutex circular locking problem in slab_attr_store() Waiman Long
2020-04-27 23:56 ` [PATCH v2 3/4] mm/slub: Fix another circular locking dependency " Waiman Long
[not found] ` <F1FA6654-C07C-42FD-B497-61EB635B264C@lca.pw>
2020-05-18 22:05 ` Waiman Long
2020-04-27 23:56 ` [PATCH v2 4/4] mm/slub: Fix sysfs shrink circular locking dependency Waiman Long
2020-04-28 0:13 ` Qian Cai
2020-04-28 1:39 ` Waiman Long
2020-04-28 2:11 ` Qian Cai
2020-04-28 14:06 ` Waiman Long
2020-04-29 2:52 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427235621.7823-1-longman@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).