From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C60EC433DF for ; Sat, 16 May 2020 17:23:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CEF032065C for ; Sat, 16 May 2020 17:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEF032065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7013F900002; Sat, 16 May 2020 13:23:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 689AF8E0001; Sat, 16 May 2020 13:23:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 578C1900002; Sat, 16 May 2020 13:23:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 3B66C8E0001 for ; Sat, 16 May 2020 13:23:16 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E4272181AC553 for ; Sat, 16 May 2020 17:23:15 +0000 (UTC) X-FDA: 76823253150.13.cork09_73c24eb946524 X-HE-Tag: cork09_73c24eb946524 X-Filterd-Recvd-Size: 7973 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 May 2020 17:23:15 +0000 (UTC) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04GH3fsn119810; Sat, 16 May 2020 13:23:11 -0400 Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 312c20hfs4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 May 2020 13:23:11 -0400 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 04GHLcRD003695; Sat, 16 May 2020 17:23:09 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma04fra.de.ibm.com with ESMTP id 3127t5rcth-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 May 2020 17:23:09 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04GHN7Lq37093434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 16 May 2020 17:23:07 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0882E5204F; Sat, 16 May 2020 17:23:07 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.205.211]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTPS id 60EBB5204E; Sat, 16 May 2020 17:23:06 +0000 (GMT) Date: Sat, 16 May 2020 20:23:04 +0300 From: Mike Rapoport To: kbuild test robot Cc: kbuild-all@lists.01.org, Johannes Weiner , Andrew Morton , Linux Memory Management List Subject: Re: [hnaz-linux-mm:master 494/523] arch/powerpc/mm/kasan/kasan_init_32.c:124:16: error: implicit declaration of function 'pmd_ptr_k'; did you mean 'pmd_off_k'? Message-ID: <20200516172304.GC1059226@linux.ibm.com> References: <202005161130.1Ey8DN41%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202005161130.1Ey8DN41%lkp@intel.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.676 definitions=2020-05-16_09:2020-05-15,2020-05-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 cotscore=-2147483648 lowpriorityscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005160148 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 16, 2020 at 11:13:33AM +0800, kbuild test robot wrote: > tree: https://github.com/hnaz/linux-mm master > head: 2bbf0589bfeb27800c730b76eacf34528eee5418 > commit: 724648314aafde8dce6440dbc849f80e45b83289 [494/523] mm: pgtable: add shortcuts for accessing kernel PMD and PTE > config: powerpc-randconfig-r002-20200515 (attached as .config) > compiler: powerpc-linux-gcc (GCC) 9.3.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 724648314aafde8dce6440dbc849f80e45b83289 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=powerpc > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > > All error/warnings (new ones prefixed by >>, old ones prefixed by <<): > > arch/powerpc/mm/kasan/kasan_init_32.c: In function 'kasan_unmap_early_shadow_vmalloc': > >> arch/powerpc/mm/kasan/kasan_init_32.c:124:16: error: implicit declaration of function 'pmd_ptr_k'; did you mean 'pmd_off_k'? [-Werror=implicit-function-declaration] > 124 | pmd_t *pmd = pmd_ptr_k(k_cur); > | ^~~~~~~~~ > | pmd_off_k > >> arch/powerpc/mm/kasan/kasan_init_32.c:124:16: warning: initialization of 'pmd_t *' {aka 'struct *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] > cc1: some warnings being treated as errors Argh, missed this one. The patch below fixes the build: >From 5abba15604ab2be0e52d0fd364def18eca8b79aa Mon Sep 17 00:00:00 2001 From: Mike Rapoport Date: Sat, 16 May 2020 19:04:09 +0300 Subject: [PATCH] powerpc/kasan: fix PMD access in kasan_unmap_early_shadow_vmalloc() The introduction of the generic shortcuts for PMD entry access broke PMD access in kasan_unmap_early_shadow_vmalloc() because the name used in powerpc for the same helper was different from the generic one. Fix it. Signed-off-by: Mike Rapoport --- arch/powerpc/mm/kasan/kasan_init_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c index 16a359ae1686..58c3b51ecd57 100644 --- a/arch/powerpc/mm/kasan/kasan_init_32.c +++ b/arch/powerpc/mm/kasan/kasan_init_32.c @@ -121,7 +121,7 @@ static void __init kasan_unmap_early_shadow_vmalloc(void) phys_addr_t pa = __pa(kasan_early_shadow_page); for (k_cur = k_start & PAGE_MASK; k_cur < k_end; k_cur += PAGE_SIZE) { - pmd_t *pmd = pmd_ptr_k(k_cur); + pmd_t *pmd = pmd_off_k(k_cur); pte_t *ptep = pte_offset_kernel(pmd, k_cur); if ((pte_val(*ptep) & PTE_RPN_MASK) != pa) -- 2.26.2 > vim +124 arch/powerpc/mm/kasan/kasan_init_32.c > > 2edb16efc899f9 Christophe Leroy 2019-04-26 115 > 3d4247fcc938d0 Christophe Leroy 2020-01-14 116 static void __init kasan_unmap_early_shadow_vmalloc(void) > 3d4247fcc938d0 Christophe Leroy 2020-01-14 117 { > 3d4247fcc938d0 Christophe Leroy 2020-01-14 118 unsigned long k_start = (unsigned long)kasan_mem_to_shadow((void *)VMALLOC_START); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 119 unsigned long k_end = (unsigned long)kasan_mem_to_shadow((void *)VMALLOC_END); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 120 unsigned long k_cur; > 3d4247fcc938d0 Christophe Leroy 2020-01-14 121 phys_addr_t pa = __pa(kasan_early_shadow_page); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 122 > 3d4247fcc938d0 Christophe Leroy 2020-01-14 123 for (k_cur = k_start & PAGE_MASK; k_cur < k_end; k_cur += PAGE_SIZE) { > 4a93b1104e586f Mike Rapoport 2020-05-16 @124 pmd_t *pmd = pmd_ptr_k(k_cur); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 125 pte_t *ptep = pte_offset_kernel(pmd, k_cur); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 126 > 3d4247fcc938d0 Christophe Leroy 2020-01-14 127 if ((pte_val(*ptep) & PTE_RPN_MASK) != pa) > 3d4247fcc938d0 Christophe Leroy 2020-01-14 128 continue; > 3d4247fcc938d0 Christophe Leroy 2020-01-14 129 > 3d4247fcc938d0 Christophe Leroy 2020-01-14 130 __set_pte_at(&init_mm, k_cur, ptep, __pte(0), 0); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 131 } > 3d4247fcc938d0 Christophe Leroy 2020-01-14 132 flush_tlb_kernel_range(k_start, k_end); > 3d4247fcc938d0 Christophe Leroy 2020-01-14 133 } > 3d4247fcc938d0 Christophe Leroy 2020-01-14 134 > > :::::: The code at line 124 was first introduced by commit > :::::: 4a93b1104e586f284c8400200eabf37a51a961bc powerpc-add-support-for-folded-p4d-page-tables-fix > > :::::: TO: Mike Rapoport > :::::: CC: Johannes Weiner > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -- Sincerely yours, Mike.