From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EAFC433DF for ; Tue, 19 May 2020 12:54:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D69BE2081A for ; Tue, 19 May 2020 12:54:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g7s/gYo8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D69BE2081A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27658900003; Tue, 19 May 2020 08:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20228900002; Tue, 19 May 2020 08:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C850900003; Tue, 19 May 2020 08:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0203.hostedemail.com [216.40.44.203]) by kanga.kvack.org (Postfix) with ESMTP id E3739900002 for ; Tue, 19 May 2020 08:54:20 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 9CA1E180AD80F for ; Tue, 19 May 2020 12:54:20 +0000 (UTC) X-FDA: 76833461880.14.dress91_7d33668755d4f X-HE-Tag: dress91_7d33668755d4f X-Filterd-Recvd-Size: 4327 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 12:54:20 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id n18so6510638pfa.2 for ; Tue, 19 May 2020 05:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G+3IDjSQe5T10VvQiPvHkruTfhZCDaHQP43VPDmYK54=; b=g7s/gYo884AOa/REioKbv6xPC+XS8JEcyTOZyZEftWHVNi/AZkMMQsZCrSmVvTpnrY bMRpbEGj1TuqSCh8GzKZKNV2c8wazABvcuQUMy7/gne30Botlu0xqkZWtMfZnocLBrAL 5fHnoBkjUSpCsvv4ff5Lyilg4RosPraY7un+SosIxJugMcYwUxvuShZD52/PUEA7ckre SDQBDX0gJ4eV4NOkL9xRDvonfqT2qH72tVBPA4oqOYpNQY7R0o72PIvznWWOmjOj/FE3 SsXorFaRT57g8d11sap/nnAvuVo/FxRunltRAhhi5NchyGxxAMaiPu9d4zBPLyuY1kNX il2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G+3IDjSQe5T10VvQiPvHkruTfhZCDaHQP43VPDmYK54=; b=jD0jH7KBhjMe2O8gwsxWcl16EKbIRSelmb+Cn1FsOHzla8lm9gIEgBGBlOPcQb5Lq8 DkqeDNFf8gFDvikD+kBIH7AKSB6cCcoydmPp8RmRqTSkiBshf+esdxC3JdIQEwnW+DE3 7hGz7hFwtS4ySmfPNNeBXqj+bJm2SqgQSUjXwi7Oz0s4JXxhzaU36PiASnxBpQD1WOFz DIZwfkygK2TKdA2VWAahlVG5IIuFNt72Vpg5Hv8nEiem8VOKrcL2X+mmiUtre5nDl+EN s9hgbjpeW72NHuIbTsvTS8JHp2evvMZcq2dbP4iIK8TJMynqX4L3CbAhyxN+fIfuW5Y1 22Pw== X-Gm-Message-State: AOAM532vf6Rf8lo79BYlIFOvS0OFu2BM8H6/ajaeHVArua3cFagrzqmg xAgB35bJbZ+RzJeGBjM7VQOYPQ== X-Google-Smtp-Source: ABdhPJyYJx833zFOzSVWomS3acnAcS+oW34Iz3pzV1ovicQc9QYaEhKOEwmBm50Nva3RBYLIqYsPgQ== X-Received: by 2002:a63:7d58:: with SMTP id m24mr17701283pgn.81.1589892858921; Tue, 19 May 2020 05:54:18 -0700 (PDT) Received: from google.com ([2620:15c:2cd:202:2523:d194:de3b:636f]) by smtp.gmail.com with ESMTPSA id q7sm9932171pgs.13.2020.05.19.05.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:54:17 -0700 (PDT) Date: Tue, 19 May 2020 05:54:15 -0700 From: Michel Lespinasse To: Vlastimil Babka Cc: Andrew Morton , linux-mm , LKML , Peter Zijlstra , Laurent Dufour , Matthew Wilcox , Liam Howlett , Jerome Glisse , Davidlohr Bueso , David Rientjes , Hugh Dickins , Ying Han , Jason Gunthorpe , Daniel Jordan Subject: Re: [PATCH v5 06/10] mmap locking API: convert nested write lock sites Message-ID: <20200519125415.GA189720@google.com> References: <20200422001422.232330-1-walken@google.com> <20200422001422.232330-7-walken@google.com> <6a23fcce-181b-01ad-4a83-ea24d07ac724@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a23fcce-181b-01ad-4a83-ea24d07ac724@suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 18, 2020 at 12:32:03PM +0200, Vlastimil Babka wrote: > On 4/22/20 2:14 AM, Michel Lespinasse wrote: > > Add API for nested write locks and convert the few call sites doing that. > > > > Signed-off-by: Michel Lespinasse > > Reviewed-by: Daniel Jordan > > Reviewed-by: Vlastimil Babka > > Perhaps we could even move SINGLE_DEPTH_NESTING into the wrapper? It's unlikely > there will be a new user with a different subclass? I think I'll leave it in the API for now. I don't foresee new uses being added as long as we stick to coarse mmap locking, but if extending the api to support range locking it'd become more likely that we'd want to lock multiple ranges for mremap... -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.