From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE28C433DF for ; Wed, 20 May 2020 19:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 76B6C206B6 for ; Wed, 20 May 2020 19:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="ejWrZ/jf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76B6C206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 01DB380007; Wed, 20 May 2020 15:09:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F3664900002; Wed, 20 May 2020 15:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFD0980007; Wed, 20 May 2020 15:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C5A9A900002 for ; Wed, 20 May 2020 15:09:10 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8488E181AEF30 for ; Wed, 20 May 2020 19:09:10 +0000 (UTC) X-FDA: 76838035260.26.arch83_6d29eb7935749 X-HE-Tag: arch83_6d29eb7935749 X-Filterd-Recvd-Size: 5266 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 20 May 2020 19:09:10 +0000 (UTC) Received: by mail-ed1-f49.google.com with SMTP id g9so4334434edw.10 for ; Wed, 20 May 2020 12:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=ejWrZ/jfJqN1W3XBa5rEh8Lk4R2pGtjUsAfERal12GI7QfCZfWLDd9UtMrTSYE1/tI FovDCSwIGfbaaHj8cZJ1IKJDULyXaqYHAyGtIE65kUKbthWtIjz/KQGrx+y85v2kRRQb 81QOjyfbBp6VHvsSe4y3k88jU+q/CRx/ohQyM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tl5hNSaq9jwtAfQ3H4b6ZmG+ScLEKqnmbeQTtX38GBs=; b=pzQ90qLaIYP98rsKF1hKa9sxWDq4BJ+4KzXRl2Ii73Q39NlcuYlYYyedmGIvCsFdGY /rOkT325CRmJCsfzCFaD5dOg2EW/yeeGhrhXMo+2duQaEZ5PIiia63JXy0YVQFquIrwt MR8sQ5DzVo446mBzd4ZZpwK3zlzVTqT3a3iIFstW0GFF81us5LTedUwbHXN8ZD6PXiUt hFZjgs2IplKUhImlbNXUUTi4EwjLIawH84GX/dfo262g+r/07UihsLbLngt0YR5Vdm4D nGBygCY44gtFle7GXYPE1lsETmjN7XGs1Gm2ttPzgRmC+kkOkHXp31+3f8i603/4njSx A9HQ== X-Gm-Message-State: AOAM531EW/xYON20PwJuvrkUZSp5zxETjgNj0HmKvGEY1IILM0CC6TxT xZYjxSKGeC3ziGIqo808F4L7xw== X-Google-Smtp-Source: ABdhPJweTP3W62AzAZrqweXxsUYkSWvtaZ1Wr8JxuA7F/wzgya+W3/hBf6pFGJ7YDBt9fmp3P99NeQ== X-Received: by 2002:a50:9312:: with SMTP id m18mr4674386eda.252.1590001748698; Wed, 20 May 2020 12:09:08 -0700 (PDT) Received: from localhost ([2620:10d:c093:400::5:758d]) by smtp.gmail.com with ESMTPSA id g21sm2514869edw.9.2020.05.20.12.09.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 12:09:08 -0700 (PDT) Date: Wed, 20 May 2020 20:09:06 +0100 From: Chris Down To: Naresh Kamboju Cc: Yafang Shao , Michal Hocko , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , cgroups@vger.kernel.org Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200520190906.GA558281@chrisdown.name> References: <20200501135806.4eebf0b92f84ab60bba3e1e7@linux-foundation.org> <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Naresh, Naresh Kamboju writes: >As a part of investigation on this issue LKFT teammate Anders Roxell >git bisected the problem and found bad commit(s) which caused this problem. > >The following two patches have been reverted on next-20200519 and retested the >reproducible steps and confirmed the test case mkfs -t ext4 got PASS. >( invoked oom-killer is gone now) > >Revert "mm, memcg: avoid stale protection values when cgroup is above >protection" > This reverts commit 23a53e1c02006120f89383270d46cbd040a70bc6. > >Revert "mm, memcg: decouple e{low,min} state mutations from protection >checks" > This reverts commit 7b88906ab7399b58bb088c28befe50bcce076d82. Thanks Anders and Naresh for tracking this down and reverting. I'll take a look tomorrow. I don't see anything immediately obviously wrong in either of those commits from a (very) cursory glance, but they should only be taking effect if protections are set. Since you have i386 hardware available, and I don't, could you please apply only "avoid stale protection" again and check if it only happens with that commit, or requires both? That would help narrow down the suspects. Do you use any memcg protections in these tests? Thank you! Chris