From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AEEC433E0 for ; Wed, 27 May 2020 04:36:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 44D9720776 for ; Wed, 27 May 2020 04:36:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RhgQiHKj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44D9720776 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 95C00800B6; Wed, 27 May 2020 00:36:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90CAE80010; Wed, 27 May 2020 00:36:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB0A800B6; Wed, 27 May 2020 00:36:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id 71AA680010 for ; Wed, 27 May 2020 00:36:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3E11D4DD6 for ; Wed, 27 May 2020 04:36:56 +0000 (UTC) X-FDA: 76861238832.16.power15_3a1758226d4f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 17492100E690C for ; Wed, 27 May 2020 04:36:56 +0000 (UTC) X-HE-Tag: power15_3a1758226d4f X-Filterd-Recvd-Size: 5736 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 04:36:55 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id v63so11279247pfb.10 for ; Tue, 26 May 2020 21:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lOpmpojWwwDKmdgvBgyDR/91akL7lsEVaaRXHGRRif0=; b=RhgQiHKjSFxt0e4hdk9XFdFmwXlaqqy/oTAekflZtHFdhEKO64qFc1mpKDXZr69CPy jdKKGgMYF3/PwLMQqZRA0p7MJV/Go6tkta/h4swizRoRpVhai4LlQKtDfpzOQXol3xcY 3TW/CBGWUO1G35QH1UIuJXs9WTI3G+E29PktRQFzMSdgmMsbx+ViIkPx4XIoQKnwHjtI iuFirKyvXOkp6bKvGs8xYK3w/Dn4sctZ1lOJtxsH8Aa2nP03Bsx7PgwJODEguoGDFtQe EV7yB1UHGazYqjCw0y7SPUOzeb1Rx+s20xn4YP/gkyyGkm4H/LKnhLTIPlstwN50FD9J kU0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lOpmpojWwwDKmdgvBgyDR/91akL7lsEVaaRXHGRRif0=; b=H0PW+dy0KQSlZsGZAx4Z78tJQyRTbw469FmJpUOsQ7Smv1O4sDZ+e36JyBAYwuclxp 7o44S0NofyRT4mawnB42pBz/sRQecg7DZD7l1+RIwLeYkzOHnyFlU/ut+gDkJe46oZim 0ftnMcu7kZWBMiWTNvqrNUNwGCLFiuvoIuxcSGRaYLKVGOarwey+w26LBecfTTLHAqtJ o4up+AGwoowtEj+EYDTrPNE0AYqcAdx617n5sbZoD/aswZ3aBA03PRsIhOAgaI1IxSp1 YlDgNQLWXOToigcOPejJ8LJmAOLF9B8aWzHWOnBhTWJcmNBFpAI/eQZDb6eguclf62Oj 6/cg== X-Gm-Message-State: AOAM531lSiFvXmJtGg4S6tqsCBtNUo8vq8zRIP0i/TaY56K244r9eNNy lwtOBiV9KKxmHpxjvew+2so= X-Google-Smtp-Source: ABdhPJxaG/pR1wu1n7WufrFJ+x4wcg8X7uq9rcDJKu3YRWfpwt3nhECM4aeG8mrZfzsEkO9ezvPt1w== X-Received: by 2002:aa7:9302:: with SMTP id 2mr2035203pfj.164.1590554214171; Tue, 26 May 2020 21:36:54 -0700 (PDT) Received: from localhost.localdomain ([2604:1380:4111:8b00::1]) by smtp.gmail.com with ESMTPSA id e13sm893604pfm.103.2020.05.26.21.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 21:36:53 -0700 (PDT) From: Nathan Chancellor To: hch@lst.de Cc: akpm@linux-foundation.org, arnd@arndb.de, jeyu@kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-c6x-dev@linux-c6x.org, linux-fsdevel@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, monstr@monstr.eu, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, zippel@linux-m68k.org, Nathan Chancellor Subject: [PATCH] media: omap3isp: Shuffle cacheflush.h and include mm.h Date: Tue, 26 May 2020 21:34:27 -0700 Message-Id: <20200527043426.3242439-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.27.0.rc0 In-Reply-To: <20200515143646.3857579-7-hch@lst.de> References: <20200515143646.3857579-7-hch@lst.de> MIME-Version: 1.0 X-Patchwork-Bot: notify X-Rspamd-Queue-Id: 17492100E690C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: After mm.h was removed from the asm-generic version of cacheflush.h, s390 allyesconfig shows several warnings of the following nature: In file included from ./arch/s390/include/generated/asm/cacheflush.h:1, from drivers/media/platform/omap3isp/isp.c:42: ./include/asm-generic/cacheflush.h:16:42: warning: 'struct mm_struct' declared inside parameter list will not be visible outside of this definition or declaration cacheflush.h does not include mm.h nor does it include any forward declaration of these structures hence the warning. To avoid this, include mm.h explicitly in this file and shuffle cacheflush.h below it. Fixes: 19c0054597a0 ("asm-generic: don't include in cacheflu= sh.h") Signed-off-by: Nathan Chancellor --- I am aware the fixes tag is kind of irrelevant because that SHA will change in the next linux-next revision and this will probably get folded into the original patch anyways but still. The other solution would be to add forward declarations of these structs to the top of cacheflush.h, I just chose to do what Christoph did in the original patch. I am happy to do that instead if you all feel that is better. drivers/media/platform/omap3isp/isp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platfo= rm/omap3isp/isp.c index a4ee6b86663e..54106a768e54 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -39,8 +39,6 @@ * Troy Laramy */ =20 -#include - #include #include #include @@ -49,6 +47,7 @@ #include #include #include +#include #include #include #include @@ -58,6 +57,8 @@ #include #include =20 +#include + #ifdef CONFIG_ARM_DMA_USE_IOMMU #include #endif --=20 2.27.0.rc0