From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C877C433E0 for ; Fri, 29 May 2020 02:49:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 958AA2075F for ; Fri, 29 May 2020 02:49:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="HfohxZ2G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 958AA2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BDB178001A; Thu, 28 May 2020 22:49:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B8C2880010; Thu, 28 May 2020 22:49:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A53DD8001A; Thu, 28 May 2020 22:49:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 8A3EE80010 for ; Thu, 28 May 2020 22:49:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4869A180AD822 for ; Fri, 29 May 2020 02:49:38 +0000 (UTC) X-FDA: 76868226036.03.balls68_5416ab06f2716 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 28EDF28A4E9 for ; Fri, 29 May 2020 02:49:38 +0000 (UTC) X-HE-Tag: balls68_5416ab06f2716 X-Filterd-Recvd-Size: 5127 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 May 2020 02:49:37 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id g28so247915qkl.0 for ; Thu, 28 May 2020 19:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bOT31TWiypZmJObYsygEhpXLQD/+7tvvPPQzjH2iK+4=; b=HfohxZ2GIu5+oSUPEPf/k32GpfCruq17SI6d356N61VFNYWJF7rv7vAleBaSQ4mpQz Ez+myrFifwvsEUyqPFS2BmS3ZHET2Oal9C6dHhaizKRmKivLz8HDqglQi/8gIg1Qa0Vi PLZ5HKzFMeGgpAswmoaxuf5dZz3ewOWmGEfqx1m2eP7NpoMk3FxEhwoohTqx3AXCMhzi gjVHzD5vzaW7EBBXYK+HvqbmCrAqDTUpnrhsCKC9pi86zHKqgkeyWe7XzLBsIAc43swa dTeWA7zG4yUzGm44EG+pcq1GGwdZBGdprgizT3/JEZ98hnCy4mnb4kauExl3LLefBGOE 2FYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bOT31TWiypZmJObYsygEhpXLQD/+7tvvPPQzjH2iK+4=; b=IvuNL5bz9Q2BhVrpy33nOqFRoUUSfTj2SW+UxV+xXV7kGmYF3wkpPIMKHsPNw21/g6 zkGy/Rivi9wjum9uNEwkVgGo4DyPB3SA/ABtzlMFbScvdPFUS32HMLyiQszT9gYJvLvi 6ORxPLpZlWvWM6BwwAI0eL6rGQ5WuW+iuaixYeEMp3Z4VWyMqPx5ONseNNuNZnz7u1k0 vaGkUhl2X1PskXQaHVMXzZfK5mZppwan0StHdAFD6nDq4z7oCFQuRZGAv5pCV/9I6aNc kga4tNyYJJN4U9JVXym0GF45EmCtx3/3M4NZ+vb1aQb/BZMVSUCIualRfChevpOqYRav Fkdg== X-Gm-Message-State: AOAM5301Yc3yTpUJQ+G3iHec1aM4E96QFHHeiEKv4dEqIpD9Kq9sWAAu Q0YDf+EFmbu/3XJxAttMhtv+Sw== X-Google-Smtp-Source: ABdhPJx2xge27p3v7EEKQbDhMTCGr7fnY6FaebGQuk8Xn7nGHqq0hgZ+nDqxhhRf3YEz8M9ySlW1OA== X-Received: by 2002:a37:688e:: with SMTP id d136mr5134004qkc.486.1590720576927; Thu, 28 May 2020 19:49:36 -0700 (PDT) Received: from lca.pw (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id a7sm6907664qth.61.2020.05.28.19.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 19:49:36 -0700 (PDT) Date: Thu, 28 May 2020 22:49:28 -0400 From: Qian Cai To: Feng Tang Cc: Andrew Morton , Michal Hocko , Johannes Weiner , Matthew Wilcox , Mel Gorman , Kees Cook , andi.kleen@intel.com, tim.c.chen@intel.com, dave.hansen@intel.com, ying.huang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Konstantin Khlebnikov Subject: Re: [PATCH v4 3/4] mm/util.c: remove the VM_WARN_ONCE for vm_committed_as underflow check Message-ID: <20200529024928.GA4566@lca.pw> References: <1590714370-67182-1-git-send-email-feng.tang@intel.com> <1590714370-67182-4-git-send-email-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590714370-67182-4-git-send-email-feng.tang@intel.com> X-Rspamd-Queue-Id: 28EDF28A4E9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 29, 2020 at 09:06:09AM +0800, Feng Tang wrote: > As is explained by Michal Hocko: > > : Looking at the history, this has been added by 82f71ae4a2b8 > : ("mm: catch memory commitment underflow") to have a safety check > : for issues which have been fixed. There doesn't seem to be any bug > : reports mentioning this splat since then so it is likely just > : spending cycles for a hot path (yes many people run with DEBUG_VM) > : without a strong reason. Hmm, it looks like the warning is still useful to catch issues in, https://lore.kernel.org/linux-mm/20140624201606.18273.44270.stgit@zurg https://lore.kernel.org/linux-mm/54BB9A32.7080703@oracle.com/ After read the whole discussion in that thread, I actually disagree with Michal. In order to get ride of this existing warning, it is rather someone needs a strong reason that could prove the performance hit is noticeable with some data. > > Signed-off-by: Feng Tang > Cc: Konstantin Khlebnikov > Cc: Qian Cai > Cc: Michal Hocko > Cc: Andi Kleen > --- > mm/util.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/mm/util.c b/mm/util.c > index 3c7a08c..fe63271 100644 > --- a/mm/util.c > +++ b/mm/util.c > @@ -814,14 +814,6 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > { > long allowed; > > - /* > - * A transient decrease in the value is unlikely, so no need > - * READ_ONCE() for vm_committed_as.count. > - */ > - VM_WARN_ONCE(data_race(percpu_counter_read(&vm_committed_as) < > - -(s64)vm_committed_as_batch * num_online_cpus()), > - "memory commitment underflow"); > - > vm_acct_memory(pages); > > /* > -- > 2.7.4 >