* [PATCH] mm: Remove misleading comment
@ 2020-05-29 12:32 Matthew Wilcox
2020-06-01 12:15 ` William Kucharski
0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2020-05-29 12:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: Matthew Wilcox (Oracle), linux-mm
From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
We no longer return 0 here and the comment doesn't tell us anything
that we don't already know (SIGBUS is a pretty good indicator that
things didn't work out).
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/filemap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 23a051a7ef0f..fe079e9219d1 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
if (!error || error == AOP_TRUNCATED_PAGE)
goto retry_find;
- /* Things didn't work out. Return zero to tell the mm layer so. */
shrink_readahead_size_eio(ra);
return VM_FAULT_SIGBUS;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: Remove misleading comment
2020-05-29 12:32 [PATCH] mm: Remove misleading comment Matthew Wilcox
@ 2020-06-01 12:15 ` William Kucharski
0 siblings, 0 replies; 2+ messages in thread
From: William Kucharski @ 2020-06-01 12:15 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Andrew Morton, linux-mm
> On May 29, 2020, at 6:32 AM, Matthew Wilcox <willy@infradead.org> wrote:
>
> From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>
> We no longer return 0 here and the comment doesn't tell us anything
> that we don't already know (SIGBUS is a pretty good indicator that
> things didn't work out).
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> mm/filemap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index 23a051a7ef0f..fe079e9219d1 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf)
> if (!error || error == AOP_TRUNCATED_PAGE)
> goto retry_find;
>
> - /* Things didn't work out. Return zero to tell the mm layer so. */
> shrink_readahead_size_eio(ra);
> return VM_FAULT_SIGBUS;
Reviewed-by: William Kucharski <william.kucharski@oracle.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-01 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-29 12:32 [PATCH] mm: Remove misleading comment Matthew Wilcox
2020-06-01 12:15 ` William Kucharski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).