From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 230B7C433E0 for ; Tue, 2 Jun 2020 15:02:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D63E52074B for ; Tue, 2 Jun 2020 15:02:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HZlUrwUU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D63E52074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 58CEC280007; Tue, 2 Jun 2020 11:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 53DA780007; Tue, 2 Jun 2020 11:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42C34280007; Tue, 2 Jun 2020 11:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0252.hostedemail.com [216.40.44.252]) by kanga.kvack.org (Postfix) with ESMTP id 26D1180007 for ; Tue, 2 Jun 2020 11:02:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DD04FB86B3 for ; Tue, 2 Jun 2020 15:02:21 +0000 (UTC) X-FDA: 76884587682.13.list63_f29d7a8e452c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 8BCD9181EC4B2 for ; Tue, 2 Jun 2020 15:01:44 +0000 (UTC) X-HE-Tag: list63_f29d7a8e452c X-Filterd-Recvd-Size: 2296 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 15:01:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aqztiuYMqiGIh8TbQtZTWQvnokYpywsvJH4dIeVj5Lk=; b=HZlUrwUUu18Htas/y2yfNP47VA Qfc3hOF/6Z+e3aTQzP9UuMLSIFh7JCanKaat5GpGpjPsjodslf5482hlaLBFSWutAO+P3Ganw0cif YrX8BKHtiGbLK1dbJSTHkekSv87WcpDBdH7WGlxE7DjaduToc/HYFHh/n2EyIXmZVOEnV8f1GPI1H 9GmLWrnC6ZrnoOUjikTYroBi3JZOcCIm178spSbN9t2N58XjKSWTTK9Xw7SH9H+0+VufkSxMDoQT1 H0aof9O61pMsoBTS2iREJc4CNRsgqP9lARzk6WDmuG7B4Ewb6eU3oudj6ssbxfnByoNe56KFQS8RO QDo1Y01w==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg8QA-00008H-1K; Tue, 02 Jun 2020 15:01:42 +0000 Date: Tue, 2 Jun 2020 08:01:41 -0700 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, hughd@google.com, Naoya Horiguchi , Zi Yan , John Hubbard , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split Message-ID: <20200602150141.GN19604@bombadil.infradead.org> References: <1590118444-21601-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1590118444-21601-1-git-send-email-anshuman.khandual@arm.com> X-Rspamd-Queue-Id: 8BCD9181EC4B2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote: > This adds the following two new VM events which will help in validating PMD > based THP migration without split. Statistics reported through these events > will help in performance debugging. > > 1. THP_PMD_MIGRATION_SUCCESS > 2. THP_PMD_MIGRATION_FAILURE There's nothing actually PMD specific about these events, is there? If we have a THP of a non-PMD size, you'd want that reported through the same statistic, wouldn't you?