From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA43C433DF for ; Tue, 2 Jun 2020 20:14:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BCE1A206E2 for ; Tue, 2 Jun 2020 20:14:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="y9pOPu5M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCE1A206E2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 679BD8004D; Tue, 2 Jun 2020 16:14:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601A080007; Tue, 2 Jun 2020 16:14:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53F718004D; Tue, 2 Jun 2020 16:14:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id 3A16480007 for ; Tue, 2 Jun 2020 16:14:09 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E9B52A4DBF for ; Tue, 2 Jun 2020 20:14:08 +0000 (UTC) X-FDA: 76885373376.28.cart77_7b7ab1b6cca51 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id CFAE69C07A for ; Tue, 2 Jun 2020 20:14:08 +0000 (UTC) X-HE-Tag: cart77_7b7ab1b6cca51 X-Filterd-Recvd-Size: 2475 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 20:14:08 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64A78207FB; Tue, 2 Jun 2020 20:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591128847; bh=XsxHgW9Ai6tTX/0JtKNyoV/Fpm9L3b7XJIBM5Cy/hZo=; h=Date:From:To:Subject:In-Reply-To:From; b=y9pOPu5MB79AOvTR46GvnDhv+86ydLZC728df6DjZYef8x5XldronUOeu+chPS/fm 1aFeTG+npA5Gz7VHxvl3/bd5qyeBP5NA8cYw8y+5bNLBWhCy2mHTil42URx4Br58Ty /Yj2qeDhf2eflyLeCs2FPgSr5yy6WgR4Dbsbc9yQ= Date: Tue, 02 Jun 2020 13:14:06 -0700 From: Andrew Morton To: akpm@linux-foundation.org, hughd@google.com, linux-mm@kvack.org, mhocko@suse.com, minchan@kernel.org, mm-commits@vger.kernel.org, tim.c.chen@linux.intel.com, torvalds@linux-foundation.org, ying.huang@intel.com Subject: [patch 072/128] mm/swapfile.c: use prandom_u32_max() Message-ID: <20200602201406.vRGSyc6UX%akpm@linux-foundation.org> In-Reply-To: <20200602130930.8e8f10fa6f19e3766e70921f@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Rspamd-Queue-Id: CFAE69C07A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Huang Ying Subject: mm/swapfile.c: use prandom_u32_max() To improve the code readability and take advantage of the common implementation. Link: http://lkml.kernel.org/r/20200512081013.520201-1-ying.huang@intel.com Signed-off-by: "Huang, Ying" Acked-by: Michal Hocko Cc: Minchan Kim Cc: Tim Chen Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/swapfile.c~mm-swap-use-prandom_u32_max +++ a/mm/swapfile.c @@ -3209,7 +3209,7 @@ SYSCALL_DEFINE2(swapon, const char __use * select a random position to start with to help wear leveling * SSD */ - p->cluster_next = 1 + (prandom_u32() % p->highest_bit); + p->cluster_next = 1 + prandom_u32_max(p->highest_bit); nr_cluster = DIV_ROUND_UP(maxpages, SWAPFILE_CLUSTER); cluster_info = kvcalloc(nr_cluster, sizeof(*cluster_info), _