From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99D7C433DF for ; Sat, 6 Jun 2020 01:08:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6C162074B for ; Sat, 6 Jun 2020 01:08:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vw2MqBpJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6C162074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 470E28E0007; Fri, 5 Jun 2020 21:08:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 420DA8E0006; Fri, 5 Jun 2020 21:08:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 337158E0007; Fri, 5 Jun 2020 21:08:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 193AD8E0006 for ; Fri, 5 Jun 2020 21:08:06 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CCF87180AD801 for ; Sat, 6 Jun 2020 01:08:05 +0000 (UTC) X-FDA: 76897000530.03.eye06_460782426da4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id A611728A4E8 for ; Sat, 6 Jun 2020 01:08:05 +0000 (UTC) X-HE-Tag: eye06_460782426da4 X-Filterd-Recvd-Size: 3668 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Sat, 6 Jun 2020 01:08:05 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2546820723; Sat, 6 Jun 2020 01:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591405684; bh=JdeeZEG/s9PJWjwa/MTfv/JgYtVWchaFYWKs9Z3jNuE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vw2MqBpJYwqq+09ZZ6vagDXamXK2QaHHbzr5ql5vspav6hv4YZxBA9Sa4ChzzdwfO f/Dh52fmkY9R8vhHgQz9fdtpn+TjCFlhSMwVVdtJ9ubadfm0w+RJfmxoaoYNQKAW1k SmUDydhrZ/piDRkHlyEgWO2OdyChN5IIcEAyO+5E= Date: Fri, 5 Jun 2020 18:08:03 -0700 From: Andrew Morton To: Bibo Mao Cc: Thomas Bogendoerfer , Paul Burton , Jiaxun Yang , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform Message-Id: <20200605180803.9ba58249ed681f4da9822f43@linux-foundation.org> In-Reply-To: <1591348266-28392-1-git-send-email-maobibo@loongson.cn> References: <1591348266-28392-1-git-send-email-maobibo@loongson.cn> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A611728A4E8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 Jun 2020 17:11:05 +0800 Bibo Mao wrote: > On MIPS system which has rixi hardware bit, page access bit is not > set in pgrot. For memory reading, there will be one page fault to > allocate physical page; however valid bit is not set, there will > be the second fast tlb-miss fault handling to set valid/access bit. > > This patch set page access/valid bit with pgrot if there is reading > access privilege. It will reduce one tlb-miss handling for memory > reading access. > > The valid/access bit will be cleared in order to track memory > accessing activity. If the page is accessed, tlb-miss fast handling > will set valid/access bit, pte_sw_mkyoung is not necessary in slow > page fault path. This patch removes pte_sw_mkyoung function which > is defined as empty function except MIPS system. > > ... > > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -2704,7 +2704,6 @@ static vm_fault_t wp_page_copy(struct vm_fault *vmf) > } > flush_cache_page(vma, vmf->address, pte_pfn(vmf->orig_pte)); > entry = mk_pte(new_page, vma->vm_page_prot); > - entry = pte_sw_mkyoung(entry); > entry = maybe_mkwrite(pte_mkdirty(entry), vma); > /* > * Clear the pte entry and flush it first, before updating the > @@ -3379,7 +3378,6 @@ static vm_fault_t do_anonymous_page(struct vm_fault *vmf) > __SetPageUptodate(page); > > entry = mk_pte(page, vma->vm_page_prot); > - entry = pte_sw_mkyoung(entry); > if (vma->vm_flags & VM_WRITE) > entry = pte_mkwrite(pte_mkdirty(entry)); > > @@ -3662,7 +3660,6 @@ vm_fault_t alloc_set_pte(struct vm_fault *vmf, struct mem_cgroup *memcg, > > flush_icache_page(vma, page); > entry = mk_pte(page, vma->vm_page_prot); > - entry = pte_sw_mkyoung(entry); > if (write) > entry = maybe_mkwrite(pte_mkdirty(entry), vma); > /* copy-on-write page */ Only affects mips, so cheerily Acked-by: Andrew Morton