Re: [PATCH v6 6/6] blktrace: fix debugfs use after free

[Luis Chamberlain <mcgrof@kernel.org>]

On Tue, Jun 09, 2020 at 11:42:34PM -0700, Christoph Hellwig wrote:
> On Tue, Jun 09, 2020 at 05:53:59PM +0000, Luis Chamberlain wrote:
> > > Feel free to add more comments, but please try to keep them short
> > > and crisp.  At the some point long comments really distract from what
> > > is going on.
> > 
> > Sure.
> > 
> > Come to think of it, given the above, I think we can also do way with
> > the the partition stuff too, and rely on the buts->name too. I'll try
> > this out, and test it.
> 
> Yes, the sg path should work for partitions as well.  That should not
> only simplify the code, but also the comments, we can do something like
> the full patch below (incorporating your original one). 

Indeed I ended up with something similar, will use this variation.

> This doesn't
> include the error check on the creation - I think that check probably
> is a good idea for this case based on the comments in the old patch, but
> also a separate issue that should go into another patch on top.

Makes sense.

  Luis