From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6A8C433DF for ; Fri, 12 Jun 2020 12:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20D9520792 for ; Fri, 12 Jun 2020 12:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20D9520792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B92698D00C0; Fri, 12 Jun 2020 08:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1A638D00A0; Fri, 12 Jun 2020 08:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 994188D00C0; Fri, 12 Jun 2020 08:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 78F168D00A0 for ; Fri, 12 Jun 2020 08:09:10 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 337C65821 for ; Fri, 12 Jun 2020 12:09:10 +0000 (UTC) X-FDA: 76920439260.22.hall38_0900fc926ddc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id F0FFC180391A9 for ; Fri, 12 Jun 2020 12:09:09 +0000 (UTC) X-HE-Tag: hall38_0900fc926ddc X-Filterd-Recvd-Size: 5061 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Jun 2020 12:09:09 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id y17so9465581wrn.11 for ; Fri, 12 Jun 2020 05:09:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0z8NpPBTC8fx2bnuG8Z/NmM1px6+WjPFa2BhCesn7bM=; b=g4cmdAYripg5k/Shah6FMhTTLfop7G5Bs49Mt7RHayIIzSBeNr4q4F5yCGi+nw0kyI igIBhIAkvMynDolL7kbEE014YSEJ6q14uHtIgsEwvBBS9ljPrz76kKUbKM5FKyUFKBfk c4ieIJak1LtoJhvWfbdMGQSp3qdjG14jxEI9+6bw+G6K4xams9aevrLS1RaxjkSTEyfk gcqNBZeRgiTlgiC2wIetpw44n5ZmjNSVQHWRtI9aRkx05sIRoxk7MW4GWCWnyj+qQie4 16A8iDsxnTKaYtMiaoq8wbUYZf5qiqo7sjNlXE1kp2bMcXSNNbs1AEVrE0bCuRrej2dP hR7g== X-Gm-Message-State: AOAM533UjRZE5YzWSXFg3mTtUfNOoioUeI+Bi5tyGAXV1W/jaQsF6yLW 7dF4jwWyn3lTcVlM/MTp8Qw= X-Google-Smtp-Source: ABdhPJz1sL62XzpDAGQuQcumUUzvpkSfg7su7rAnvTQ7e/vCPEMTYoz1QoY8w+Uh8QVrBnRvZKmM4A== X-Received: by 2002:a05:6000:1104:: with SMTP id z4mr14545075wrw.272.1591963748046; Fri, 12 Jun 2020 05:09:08 -0700 (PDT) Received: from localhost (ip-37-188-174-201.eurotel.cz. [37.188.174.201]) by smtp.gmail.com with ESMTPSA id a3sm9652169wrp.91.2020.06.12.05.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 05:09:06 -0700 (PDT) Date: Fri, 12 Jun 2020 14:09:04 +0200 From: Michal Hocko To: Naresh Kamboju Cc: Chris Down , Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200612120904.GA8641@dhcp22.suse.cz> References: <20200528150310.GG27484@dhcp22.suse.cz> <20200528164121.GA839178@chrisdown.name> <20200529015644.GA84588@chrisdown.name> <20200529094910.GH4406@dhcp22.suse.cz> <20200611095514.GD20450@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: F0FFC180391A9 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 12-06-20 15:13:22, Naresh Kamboju wrote: > On Thu, 11 Jun 2020 at 15:25, Michal Hocko wrote: > > > > On Fri 29-05-20 11:49:20, Michal Hocko wrote: > > > On Fri 29-05-20 02:56:44, Chris Down wrote: > > > > Yafang Shao writes: > > > Agreed. Even if e{low,min} might still have some rough edges I am > > > completely puzzled how we could end up oom if none of the protection > > > path triggers which the additional debugging should confirm. Maybe my > > > debugging patch is incomplete or used incorrectly (maybe it would be > > > esier to use printk rather than trace_printk?). > > > > It would be really great if we could move forward. While the fix (which > > has been dropped from mmotm) is not super urgent I would really like to > > understand how it could hit the observed behavior. Can we double check > > that the debugging patch really doesn't trigger (e.g. > > s@trace_printk@printk in the first step)? > > Please suggest to me the way to get more debug information > by providing kernel debug patches and extra kernel configs. > > I have applied your debug patch and tested on top on linux next 20200612 > but did not find any printk output while running mkfs -t ext4 /drive test case. Have you tried s@trace_printk@printk@ in the patch? AFAIK trace_printk doesn't dump anything into the printk ring buffer. You would have to look into trace ring buffer. -- Michal Hocko SUSE Labs