From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A888CC433DF for ; Tue, 16 Jun 2020 09:27:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7379320767 for ; Tue, 16 Jun 2020 09:27:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7379320767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD36D6B0075; Tue, 16 Jun 2020 05:27:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C83746B007B; Tue, 16 Jun 2020 05:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B994B6B007D; Tue, 16 Jun 2020 05:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0023.hostedemail.com [216.40.44.23]) by kanga.kvack.org (Postfix) with ESMTP id 9F69D6B0075 for ; Tue, 16 Jun 2020 05:27:37 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 28A4F1DF9 for ; Tue, 16 Jun 2020 09:27:37 +0000 (UTC) X-FDA: 76934547354.05.news60_3011a9b26dfd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id DF9451802747F for ; Tue, 16 Jun 2020 09:27:36 +0000 (UTC) X-HE-Tag: news60_3011a9b26dfd X-Filterd-Recvd-Size: 6693 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 09:27:36 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id f7so20737348ejq.6 for ; Tue, 16 Jun 2020 02:27:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HQVEwzF61pJG67w4VVFyK6E5C1QP2FoVP3jQ17g95ks=; b=hQhIvPtzIV6uD3h13NPI6iuZBg0RABTN+2KMxetLAbb/IgKP0WianEspv1/ckeY9OW BmtXe0Mnyy7ze2sr8yraOA6GaXIDoiSo2Clag7UqRl/o1ZK+/W2luwF5z2KNqctx5Ter enH8uB5GhwVQNkM2/jvIq6nAiZR/R/r5hOXzGlyosApnpXPe4ykCvRKXuEjCgsiI912F 349bxct6XrlBs0pioRyyElsKHwn/4Qfcpi3InpRgExTk95G1GsJR/E4kM6AOnyFldmxn 9WCvsQ/0QsfoQrHdDVYO/kbdv2aReYMCApGo3wWlzbGuPxhoPMpZeJhnVV58/t2S3mWw SyUA== X-Gm-Message-State: AOAM530rxt6M/ZFByT69x9xoIhux6P0zUNCZP4nvB12bWHaq5pEiTgmO OH0mZZxZwulVlKt1nQm7xgc= X-Google-Smtp-Source: ABdhPJzgkkE5RAtuOPXtr3stKyyC1FyTvZ9fNK0/KUpTftRx6B56W2cpdvndiDarNtDvhPe+zX8URQ== X-Received: by 2002:a17:906:ca54:: with SMTP id jx20mr2010240ejb.549.1592299655323; Tue, 16 Jun 2020 02:27:35 -0700 (PDT) Received: from localhost (ip-37-188-174-201.eurotel.cz. [37.188.174.201]) by smtp.gmail.com with ESMTPSA id a7sm9803383edx.3.2020.06.16.02.27.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 02:27:34 -0700 (PDT) Date: Tue, 16 Jun 2020 11:27:27 +0200 From: Michal Hocko To: Yafang Shao Cc: Christoph Hellwig , Dave Chinner , "Darrick J. Wong" , Andrew Morton , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Linux MM Subject: Re: [PATCH v3] xfs: avoid deadlock when trigger memory reclaim in ->writepages Message-ID: <20200616092727.GD9499@dhcp22.suse.cz> References: <1592222181-9832-1-git-send-email-laoar.shao@gmail.com> <20200616081628.GC9499@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DF9451802747F X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 16-06-20 17:05:25, Yafang Shao wrote: > On Tue, Jun 16, 2020 at 4:16 PM Michal Hocko wrote: > > > > On Mon 15-06-20 07:56:21, Yafang Shao wrote: > > > Recently there is a XFS deadlock on our server with an old kernel. > > > This deadlock is caused by allocating memory in xfs_map_blocks() while > > > doing writeback on behalf of memroy reclaim. Although this deadlock happens > > > on an old kernel, I think it could happen on the upstream as well. This > > > issue only happens once and can't be reproduced, so I haven't tried to > > > reproduce it on upsteam kernel. > > > > > > Bellow is the call trace of this deadlock. > > > [480594.790087] INFO: task redis-server:16212 blocked for more than 120 seconds. > > > [480594.790087] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > > > [480594.790088] redis-server D ffffffff8168bd60 0 16212 14347 0x00000004 > > > [480594.790090] ffff880da128f070 0000000000000082 ffff880f94a2eeb0 ffff880da128ffd8 > > > [480594.790092] ffff880da128ffd8 ffff880da128ffd8 ffff880f94a2eeb0 ffff88103f9d6c40 > > > [480594.790094] 0000000000000000 7fffffffffffffff ffff88207ffc0ee8 ffffffff8168bd60 > > > [480594.790096] Call Trace: > > > [480594.790101] [] schedule+0x29/0x70 > > > [480594.790103] [] schedule_timeout+0x239/0x2c0 > > > [480594.790111] [] io_schedule_timeout+0xae/0x130 > > > [480594.790114] [] io_schedule+0x18/0x20 > > > [480594.790116] [] bit_wait_io+0x11/0x50 > > > [480594.790118] [] __wait_on_bit+0x65/0x90 > > > [480594.790121] [] wait_on_page_bit+0x81/0xa0 > > > [480594.790125] [] shrink_page_list+0x6d2/0xaf0 > > > [480594.790130] [] shrink_inactive_list+0x223/0x710 > > > [480594.790135] [] shrink_lruvec+0x3b5/0x810 > > > [480594.790139] [] shrink_zone+0xba/0x1e0 > > > [480594.790141] [] do_try_to_free_pages+0x100/0x510 > > > [480594.790143] [] try_to_free_mem_cgroup_pages+0xdd/0x170 > > > [480594.790145] [] mem_cgroup_reclaim+0x4e/0x120 > > > [480594.790147] [] __mem_cgroup_try_charge+0x41c/0x670 > > > [480594.790153] [] __memcg_kmem_newpage_charge+0xf6/0x180 > > > [480594.790157] [] __alloc_pages_nodemask+0x22d/0x420 > > > [480594.790162] [] alloc_pages_current+0xaa/0x170 > > > [480594.790165] [] new_slab+0x30c/0x320 > > > [480594.790168] [] ___slab_alloc+0x3ac/0x4f0 > > > [480594.790204] [] __slab_alloc+0x40/0x5c > > > [480594.790206] [] kmem_cache_alloc+0x193/0x1e0 > > > [480594.790233] [] kmem_zone_alloc+0x97/0x130 [xfs] > > > [480594.790247] [] _xfs_trans_alloc+0x3a/0xa0 [xfs] > > > [480594.790261] [] xfs_trans_alloc+0x3c/0x50 [xfs] > > > > Now with a more explanation from Dave I have got back to the original > > backtrace. Not sure which kernel version you are using but this path > > should have passed xfs_trans_reserve which sets PF_MEMALLOC_NOFS and > > this in turn should have made __alloc_pages_nodemask to use __GFP_NOFS > > and the memcg reclaim shouldn't ever wait_on_page_writeback (pressumably > > this is what the io_schedule is coming from). > > Hi Michal, > > The page is allocated before calling xfs_trans_reserve, so the > PF_MEMALLOC_NOFS hasn't been set yet. > See bellow, > > xfs_trans_alloc > kmem_zone_zalloc() <<< GPF_NOFS hasn't been set yet, but it may > trigger memory reclaim > xfs_trans_reserve() <<<< GPF_NOFS is set here (for the kernel > prior to commit 9070733b4efac, it is PF_FSTRANS) You are right, I have misread the actual allocation side. 8683edb7755b8 has added KM_NOFS and 73d30d48749f8 has removed it. I cannot really judge the correctness here. -- Michal Hocko SUSE Labs