Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c)

Richard Weinberger
2020-06-22T22:01:06Z

On Mon, Jun 22, 2020 at 11:51 PM Kees Cook <keescook@chromium.org> wrote:
>
> On Mon, Jun 22, 2020 at 08:37:17AM -0700, Randy Dunlap wrote:
> > On 6/20/20 9:37 PM, akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2020-06-20-21-36 has been uploaded to
> > >
> > > http://www.ozlabs.org/~akpm/mmotm/
> > >
> > > mmotm-readme.txt says
> > >
> > > README for mm-of-the-moment:
> > >
> > > http://www.ozlabs.org/~akpm/mmotm/
> > >
> > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> > > more than once a week.
> >
> > drivers/misc/lkdtm/bugs.c has build errors when building UML for i386
> > (allmodconfig or allyesconfig):
> >
> >
> > In file included from ../drivers/misc/lkdtm/bugs.c:17:0:
> > ../arch/x86/um/asm/desc.h:7:0: warning: "LDT_empty" redefined
> > #define LDT_empty(info) (\
> >
> > In file included from ../arch/um/include/asm/mmu.h:10:0,
> > from ../include/linux/mm_types.h:18,
> > from ../include/linux/sched/signal.h:13,
> > from ../drivers/misc/lkdtm/bugs.c:11:
> > ../arch/x86/um/asm/mm_context.h:65:0: note: this is the location of the previous definition
> > #define LDT_empty(info) (_LDT_empty(info))
>
> The LKDTM test landed a while ago:
> b09511c253e5 ("lkdtm: Add a DOUBLE_FAULT crash type on x86")
>
> and nothing has touched arch/x86/um/asm/desc.h nor
> arch/x86/um/asm/mm_context.h in a while either.
>
> Regardless, it seems arch/x86/um/asm/desc.h is not needed any more?

True that, we can rip the file.

--
Thanks,
//richard