From: "Matthew Wilcox (Oracle)" <willy@infradead.org>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH 2/3] mm: Print the inode number in dump_page
Date: Mon, 29 Jun 2020 16:19:17 +0100 [thread overview]
Message-ID: <20200629151918.15537-3-willy@infradead.org> (raw)
In-Reply-To: <20200629151918.15537-1-willy@infradead.org>
The inode number helps correlate this page with debug messages elsewhere
in the kernel.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
mm/debug.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/mm/debug.c b/mm/debug.c
index 44d843b3b07c..5c58d4509dc9 100644
--- a/mm/debug.c
+++ b/mm/debug.c
@@ -134,14 +134,16 @@ void __dump_page(struct page *page, const char *reason)
}
if (copy_from_kernel_nofault(&dentry_first,
- &host->i_dentry.first, sizeof(struct hlist_node *))) {
+ &host->i_dentry.first,
+ sizeof(struct hlist_node *))) {
pr_warn("mapping->a_ops:%ps with invalid mapping->host inode address %px\n",
a_ops, host);
goto out_mapping;
}
if (!dentry_first) {
- pr_warn("mapping->a_ops:%ps\n", a_ops);
+ pr_warn("mapping->a_ops:%ps ino %lx\n", a_ops,
+ host->i_ino);
goto out_mapping;
}
@@ -156,8 +158,8 @@ void __dump_page(struct page *page, const char *reason)
* crash, but it's unlikely that we reach here with a
* corrupted struct page
*/
- pr_warn("mapping->aops:%ps dentry name:\"%pd\"\n",
- a_ops, &dentry);
+ pr_warn("mapping->aops:%ps ino %lx dentry name:\"%pd\"\n",
+ a_ops, host->i_ino, &dentry);
}
}
out_mapping:
--
2.27.0
next prev parent reply other threads:[~2020-06-29 15:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 15:19 [PATCH 0/3] Improvements for dump_page() Matthew Wilcox (Oracle)
2020-06-29 15:19 ` [PATCH 1/3] mm: Print head flags in dump_page Matthew Wilcox (Oracle)
2020-06-29 22:38 ` John Hubbard
2020-06-29 22:51 ` Matthew Wilcox
2020-06-29 22:54 ` John Hubbard
2020-06-29 23:35 ` John Hubbard
2020-06-30 8:02 ` Vlastimil Babka
2020-06-30 11:59 ` Matthew Wilcox
2020-07-01 2:12 ` John Hubbard
2020-07-02 14:59 ` Vlastimil Babka
2020-07-02 15:53 ` Kirill A. Shutemov
2020-07-02 16:19 ` Vlastimil Babka
2020-07-02 20:39 ` Kirill A. Shutemov
2020-07-02 21:01 ` Matthew Wilcox
2020-06-29 15:19 ` Matthew Wilcox (Oracle) [this message]
2020-06-29 15:19 ` [PATCH 3/3] mm: Print hashed address of struct page Matthew Wilcox (Oracle)
2020-07-02 15:56 ` Kirill A. Shutemov
2020-06-29 16:57 ` [PATCH 0/3] Improvements for dump_page() William Kucharski
2020-06-29 20:17 ` Mike Rapoport
2020-06-29 21:55 ` John Hubbard
2020-06-29 22:35 ` Matthew Wilcox
2020-06-29 23:41 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629151918.15537-3-willy@infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).