From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB1EBC433DF for ; Mon, 29 Jun 2020 15:20:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7E2A4246B7 for ; Mon, 29 Jun 2020 15:20:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="iEibZzk2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E2A4246B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66BAA6B0036; Mon, 29 Jun 2020 11:20:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640C16B0037; Mon, 29 Jun 2020 11:20:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E1166B0055; Mon, 29 Jun 2020 11:20:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 37D6B6B0036 for ; Mon, 29 Jun 2020 11:20:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EE6871EE6 for ; Mon, 29 Jun 2020 15:20:09 +0000 (UTC) X-FDA: 76982610138.07.start76_260a8e126e70 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id BBBE91803FFCF for ; Mon, 29 Jun 2020 15:20:09 +0000 (UTC) X-HE-Tag: start76_260a8e126e70 X-Filterd-Recvd-Size: 2762 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 15:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=menTY62kjyGrIRN3icws339nMBHzO/L6TdGFnfxXMz4=; b=iEibZzk2LDFfymlDWnch/quZ2i pnh4wAzX8lJlVwdQs6gSVsGx4AtL0pO3UUsF80HydBruohQ+P3LVYMKOaLAHJQ8Xd9rMpg2MXFa6f EwEeuUTRpnDoGCxRq0W7uQftYxdWnKzIGkYy/xSsLWXIq/V373yZS+kAYg/p8M3/LIORmvsDmM8jK wxwZeTr2ZPVep9YjxQyrx1xxxAAas/caO5SANlxSQMzjj0QD8j5Jo43hm9ylGyOFQP2M8AmYBMna/ s+JpwWx5rBFQ2HNGggYIO2gtzSmVjzHG55Y0CNHumRNL9oHB71ntyL4aRskmIWTeIsTaqR/NRk7GD 6ydrbjSg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpvZn-0004C6-SO; Mon, 29 Jun 2020 15:20:08 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Cc: "Matthew Wilcox (Oracle)" Subject: [PATCH 2/7] mm: Move page-flags include to top of file Date: Mon, 29 Jun 2020 16:19:54 +0100 Message-Id: <20200629151959.15779-3-willy@infradead.org> X-Mailer: git-send-email 2.21.3 In-Reply-To: <20200629151959.15779-1-willy@infradead.org> References: <20200629151959.15779-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: BBBE91803FFCF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Give up on the notion that we can remove page-flags.h from mm.h. There are currently 14 inline functions which use a PageFoo function. Also, two of the files directly included by mm.h include page-flags.h themselves, and there are probably more indirect inclusions. So just include it at the top like any other header file. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/mm.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index af0305ad090f..6c29b663135f 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -24,6 +24,7 @@ #include #include #include +#include #include #include #include @@ -667,11 +668,6 @@ int vma_is_stack_for_current(struct vm_area_struct *= vma); struct mmu_gather; struct inode; =20 -/* - * FIXME: take this include out, include page-flags.h in - * files which need it (119 of them) - */ -#include #include =20 /* --=20 2.27.0