From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D13C433DF for ; Mon, 29 Jun 2020 16:24:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6766E25590 for ; Mon, 29 Jun 2020 16:24:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SqTiqegE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6766E25590 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7BF26B0095; Mon, 29 Jun 2020 12:24:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D04CF6B0096; Mon, 29 Jun 2020 12:24:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1ACB6B0098; Mon, 29 Jun 2020 12:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id A62956B0095 for ; Mon, 29 Jun 2020 12:24:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 327F62C81 for ; Mon, 29 Jun 2020 16:24:14 +0000 (UTC) X-FDA: 76982771628.04.drop08_0a104f226e70 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 42D308009E84 for ; Mon, 29 Jun 2020 16:24:13 +0000 (UTC) X-HE-Tag: drop08_0a104f226e70 X-Filterd-Recvd-Size: 2358 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 16:24:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PM2ctrNamI+FuCpU5ETwwiM78ezO5gsP8HYNzHGPK0g=; b=SqTiqegEftG01FRCWEr7nyvyYH x89Sbz8RMBrBwBK6WIffkxlZP36qXgEAsMeZOWx7/ZKU/+Ty9dPzhrmFe5Zy6vyOyMHnlGI+2cymu gwExiSBJV0sTO1HkpM/qg4TnH8XXBZ8sZhrRFH4zLtZFd6slTOWVsjMnUk7JXIydEwOPy9x7tMhEh CGq9uuvGwU9ojXVhvAKizOgwL2PbRLowD4h84hyX2CZL85haOroMg7Wxg1kGnxqdvprGRf1T/XhUz 5gybG0fReig7OrRpC36+52r0GCUI8TDV/VM6YIlgC6E7kYPYEZ2XPyltmwtgRWkP+uk7hgW6RQVIe 9qKf39jg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwZh-0008Uy-LK; Mon, 29 Jun 2020 16:24:05 +0000 Date: Mon, 29 Jun 2020 17:24:05 +0100 From: Matthew Wilcox To: Ira Weiny Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH 1/7] mm: Store compound_nr as well as compound_order Message-ID: <20200629162405.GF25523@casper.infradead.org> References: <20200629151959.15779-1-willy@infradead.org> <20200629151959.15779-2-willy@infradead.org> <20200629162227.GF2454695@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629162227.GF2454695@iweiny-DESK2.sc.intel.com> X-Rspamd-Queue-Id: 42D308009E84 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 29, 2020 at 09:22:27AM -0700, Ira Weiny wrote: > On Mon, Jun 29, 2020 at 04:19:53PM +0100, Matthew Wilcox wrote: > > static inline void set_compound_order(struct page *page, unsigned int order) > > { > > page[1].compound_order = order; > > + page[1].compound_nr = 1U << order; > ^^^ > 1UL? > > Ira > > > +++ b/include/linux/mm_types.h > > @@ -134,6 +134,7 @@ struct page { > > unsigned char compound_dtor; > > unsigned char compound_order; > > atomic_t compound_mapcount; > > + unsigned int compound_nr; /* 1 << compound_order */ ^^^^^^^^^^^^ No