From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0AFCC433E1 for ; Wed, 1 Jul 2020 09:06:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B9C162078A for ; Wed, 1 Jul 2020 09:06:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AhI5YsV1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9C162078A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2470B8D0029; Wed, 1 Jul 2020 05:06:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F87C8D0024; Wed, 1 Jul 2020 05:06:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BFEA8D0029; Wed, 1 Jul 2020 05:06:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id EB3118D0024 for ; Wed, 1 Jul 2020 05:06:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8EF19181AC9CC for ; Wed, 1 Jul 2020 09:06:30 +0000 (UTC) X-FDA: 76988926140.08.fruit36_110bfaf26e7f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 767DD1819E769 for ; Wed, 1 Jul 2020 09:06:30 +0000 (UTC) X-HE-Tag: fruit36_110bfaf26e7f X-Filterd-Recvd-Size: 2747 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 09:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=dEDCWXfjhVQGOOrCUmr0J53WrGJ1BtJhis14QIiQIQk=; b=AhI5YsV13Iv7q6tUnnLzpio3XP uAnzpDzGCx6Ne6ojt9Q+KH1At6DZKdynwMnkdI7IGyo995agZAB2NSOTiBd+k3DHKYC8B4CLEtNKE TtveQ2NbJsuJBjtkhUCvdfcJHAfgI2c/EtuxG/XKf8oPBGJwkkW5zSkOe/ljCB8bu2JfgRYUCFnIe rydsCUFaIKQYUGqxkAEPTNu7R8xCBYr5/7/x0U6Sua8CbuGNZu7da7vhukC4ljxsIpqvwi+UcNaYv tJJ6g6Avyvsz13KgZDujJKiTYSeikkjJhpUn+t/sqWC6SJT1aq3a15v82WckDhWs2sK8ooGi2mECN 62jUTcnA==; Received: from [2001:4bb8:184:76e3:ea38:596b:3e9e:422a] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqYhF-0000hb-3M; Wed, 01 Jul 2020 09:06:25 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] drbd: remove a bogus bdi_rw_congested call Date: Wed, 1 Jul 2020 11:06:19 +0200 Message-Id: <20200701090622.3354860-2-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200701090622.3354860-1-hch@lst.de> References: <20200701090622.3354860-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 767DD1819E769 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: bdi_rw_congested returns congestion state, so calling it without looking at the return value doesn't make much sense. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_proc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/drbd/drbd_proc.c b/drivers/block/drbd/drbd_pro= c.c index 1c41cd9982a257..3c0193de249830 100644 --- a/drivers/block/drbd/drbd_proc.c +++ b/drivers/block/drbd/drbd_proc.c @@ -265,7 +265,6 @@ int drbd_seq_show(struct seq_file *seq, void *v) seq_printf(seq, "%2d: cs:Unconfigured\n", i); } else { /* reset device->congestion_reason */ - bdi_rw_congested(device->rq_queue->backing_dev_info); =20 nc =3D rcu_dereference(first_peer_device(device)->connection->net_con= f); wp =3D nc ? nc->wire_protocol - DRBD_PROT_A + 'A' : ' '; --=20 2.26.2