From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLACK,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45457C433DF for ; Wed, 1 Jul 2020 16:00:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14E3420780 for ; Wed, 1 Jul 2020 16:00:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14E3420780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B0A88D0031; Wed, 1 Jul 2020 12:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 838FE8D0016; Wed, 1 Jul 2020 12:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D9428D0031; Wed, 1 Jul 2020 12:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 545768D0016 for ; Wed, 1 Jul 2020 12:00:52 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CB9A78248068 for ; Wed, 1 Jul 2020 16:00:51 +0000 (UTC) X-FDA: 76989970302.23.jar18_1017ace26e81 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 3916337614 for ; Wed, 1 Jul 2020 16:00:51 +0000 (UTC) X-HE-Tag: jar18_1017ace26e81 X-Filterd-Recvd-Size: 3650 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 16:00:49 +0000 (UTC) IronPort-SDR: +qMPrhBE81k7ptpA+qLPTm5ygv95TWcNxplHc0Le/swBpHP/xprCofJs1LvIKNFLeSKr1Cptsr w5zcnHsQDikA== X-IronPort-AV: E=McAfee;i="6000,8403,9669"; a="146613067" X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="146613067" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 09:00:48 -0700 IronPort-SDR: vz7kfNqPAzOP9Ja+liVBuA7NBVbHoPStgbItBpDF7drpSr0G0tkUuRn2+T1KFZoMIIWAB0FdGF PH51FTVD7Vnw== X-IronPort-AV: E=Sophos;i="5.75,300,1589266800"; d="scan'208";a="425636457" Received: from sadedonx-mobl2.amr.corp.intel.com (HELO intel.com) ([10.252.134.113]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2020 09:00:47 -0700 Date: Wed, 1 Jul 2020 09:00:46 -0700 From: Ben Widawsky To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com, dan.j.williams@intel.com, cai@lca.pw Subject: Re: [PATCH 0/3] [v2] Repair and clean up vm.zone_reclaim_mode sysctl ABI Message-ID: <20200701160046.kvhsq43adcw46fbq@intel.com> Mail-Followup-To: Dave Hansen , linux-kernel@vger.kernel.org, linux-mm@kvack.org, alex.shi@linux.alibaba.com, dwagner@suse.de, tobin@kernel.org, cl@linux.com, akpm@linux-foundation.org, ying.huang@intel.com, dan.j.williams@intel.com, cai@lca.pw References: <20200701152621.D520E62B@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200701152621.D520E62B@viggo.jf.intel.com> X-Rspamd-Queue-Id: 3916337614 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20-07-01 08:26:21, Dave Hansen wrote: > A previous cleanup accidentally changed the vm.zone_reclaim_mode ABI. > > This series restores the ABI and then reorganizes the code to make > the ABI more obvious. Since the single-patch v1[1], I've: > > * Restored the RECLAIM_ZONE naming, comment and Documentation now > that the implicit checks for it are known. > * Move RECLAIM_* definitions to a uapi header > * Add a node_reclaim_enabled() helper > > Documentation/admin-guide/sysctl/vm.rst | 10 +++++----- > include/linux/swap.h | 7 +++++++ > include/uapi/linux/mempolicy.h | 7 +++++++ > mm/khugepaged.c | 2 +- > mm/page_alloc.c | 2 +- > mm/vmscan.c | 3 --- > 6 files changed, 21 insertions(+), 10 deletions(-) > > 1. https://lore.kernel.org/linux-mm/20200626003459.D8E015CA@viggo.jf.intel.com/ > > Cc: Ben Widawsky > Cc: Alex Shi > Cc: Daniel Wagner > Cc: "Tobin C. Harding" > Cc: Christoph Lameter > Cc: Andrew Morton > Cc: Huang Ying > Cc: Dan Williams > Cc: Qian Cai > Cc: Daniel Wagner Series is: Reviewed-by: Ben Widawsky I was more thorough this time in checking all uses of node_reclaim_mode :-). I do think in patch 2/3, using an enum would be a little better, which I've mentioned there.