From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FCDFC433E1 for ; Fri, 3 Jul 2020 19:04:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 431352073E for ; Fri, 3 Jul 2020 19:04:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fGZzcO/5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 431352073E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B112A8D0055; Fri, 3 Jul 2020 15:04:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC1028D0030; Fri, 3 Jul 2020 15:04:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6F68D0055; Fri, 3 Jul 2020 15:04:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0145.hostedemail.com [216.40.44.145]) by kanga.kvack.org (Postfix) with ESMTP id 87E7C8D0030 for ; Fri, 3 Jul 2020 15:04:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2FF688245571 for ; Fri, 3 Jul 2020 19:04:39 +0000 (UTC) X-FDA: 76997691078.22.tree26_63049bc26e94 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id DF44118038E6A for ; Fri, 3 Jul 2020 19:04:38 +0000 (UTC) X-HE-Tag: tree26_63049bc26e94 X-Filterd-Recvd-Size: 2418 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 19:04:38 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47E8F20724; Fri, 3 Jul 2020 19:04:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593803077; bh=4pNuCfQIqgQH3q0qc1Q3ebM/lBgF6HLbGev3V+Gg3Iw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fGZzcO/5l+ihymtMX7ExVRl++j9zpGqwlnEhhHiQ7yQh/37hgSTJv4wfEMhdyfLqa YffdWJZcD+4yC9HaaDIv1j9KMSvKHAVfquU7AqjMPjmtmTIUL8nT3HyXHYSlmUBNzx CtsviZnp3/WcL3iIzm2yYrOT7U5wbqTo8kzkPu9o= Date: Fri, 3 Jul 2020 12:04:36 -0700 From: Andrew Morton To: trix@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: initialize return of vm_insert_pages Message-Id: <20200703120436.4031b4ea23e28a3babca3d2d@linux-foundation.org> In-Reply-To: <20200703155354.29132-1-trix@redhat.com> References: <20200703155354.29132-1-trix@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DF44118038E6A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Jul 2020 08:53:54 -0700 trix@redhat.com wrote: > From: Tom Rix > > clang static analysis reports a garbage return > > In file included from mm/memory.c:84: > mm/memory.c:1612:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] > return err; > ^~~~~~~~~~ > > The setting of err depends on a loop executing. > So initialize err. > > ... > > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -1601,7 +1601,7 @@ int vm_insert_pages(struct vm_area_struct *vma, unsigned long addr, > return insert_pages(vma, addr, pages, num, vma->vm_page_prot); > #else > unsigned long idx = 0, pgcount = *num; > - int err; > + int err = -EINVAL; > > for (; idx < pgcount; ++idx) { > err = vm_insert_page(vma, addr + (PAGE_SIZE * idx), pages[idx]); If a caller were to ask vm_insert_pages() to insert zero pages, I suspect we should just return zero and set *num to zero.