From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F274C433E0 for ; Tue, 7 Jul 2020 22:50:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 417AC20720 for ; Tue, 7 Jul 2020 22:50:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="IQIEdRPn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 417AC20720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED1DF6B0081; Tue, 7 Jul 2020 18:50:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEB346B00A5; Tue, 7 Jul 2020 18:50:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B25266B0081; Tue, 7 Jul 2020 18:50:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 807426B0081 for ; Tue, 7 Jul 2020 18:50:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 42E0B8248D52 for ; Tue, 7 Jul 2020 22:50:31 +0000 (UTC) X-FDA: 77012775462.22.team72_5d1674d26eb8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 1724418038E60 for ; Tue, 7 Jul 2020 22:50:31 +0000 (UTC) X-HE-Tag: team72_5d1674d26eb8 X-Filterd-Recvd-Size: 5788 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jul 2020 22:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594162229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9zINhPgn0dLU827u0kCMWiXWqm1EOoX2bkCYV8BQtz4=; b=IQIEdRPnIugyLmM3EWvcgS/XmZwMrBujl7wzUgL1V5ihOG9+bvnqcxqYrTMUPU4RV8z6Mo xTQpbeVsMLXZlverL7E/OzxRmO/hj/CZAH9Gz1kVoIXGS4IZMXVIdd/WFcsxeidVwWnvDo NGeL0abZCbXjeoiTdRW+c1B41EBTzbs= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-220-JPxlKqHqM-O0HdDGURFRRQ-1; Tue, 07 Jul 2020 18:50:28 -0400 X-MC-Unique: JPxlKqHqM-O0HdDGURFRRQ-1 Received: by mail-qt1-f199.google.com with SMTP id c26so31749846qtq.6 for ; Tue, 07 Jul 2020 15:50:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9zINhPgn0dLU827u0kCMWiXWqm1EOoX2bkCYV8BQtz4=; b=tB5uG0vmrzHbR0PBlOBiwmauIFSjZOrn6msdQBxHE5Zy24jUr190RPXwFRrQNgIKVn YQrCMLNtejKIXpW8QfZJzA03q1QyUxAmKl9tVnBIQ5OoGFxQRiZpb/NZTk8K25XUbGwc qo5Fn9Sy5+MaXKibhtraRbxiQQYdSQCE/SmqFMiSze/yfggMQx+mmNl7WMnaSY/iDiUt xWNr5O3MmsGvNMOXHP18VOvlDNDO7Z5cLWYtCwyX9JE3N4YsdIqEMdOnfgmMZf4Vep+R kQXQ+32ot1V9uzgLv98Hz8h3rC5qkVSGBtnMJEQ1GR+OI+tR94dCW9aijVgFDcDoXZuV DTIg== X-Gm-Message-State: AOAM532YcrvYA11FVBbHKt3MVQrrb0SiMgW2ZNh295XpZki/uKxcmTUi 6k262YJJrakunszhwd//Dt0KgbRyfBmb3TZoeEWiSpLOGrZdvgXqUqD7Jf8jGWXzY1/2LKqk3Y1 ERTf5HhPPMmI= X-Received: by 2002:ac8:7b57:: with SMTP id m23mr36398732qtu.379.1594162227887; Tue, 07 Jul 2020 15:50:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjtNA8lnpn1m/KE5+eQlmjotnypaLOF4WLVE5X368ySfVMh096MOzRrWMEJA23JXXqHHd3XA== X-Received: by 2002:ac8:7b57:: with SMTP id m23mr36398711qtu.379.1594162227647; Tue, 07 Jul 2020 15:50:27 -0700 (PDT) Received: from xz-x1.redhat.com ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id j16sm26267642qtp.92.2020.07.07.15.50.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jul 2020 15:50:27 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Gerald Schaefer , Linus Torvalds , peterx@redhat.com, Andrew Morton , Will Deacon , Andrea Arcangeli , David Rientjes , John Hubbard , Michael Ellerman , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Subject: [PATCH v5 02/25] mm/alpha: Use general page fault accounting Date: Tue, 7 Jul 2020 18:49:58 -0400 Message-Id: <20200707225021.200906-3-peterx@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200707225021.200906-1-peterx@redhat.com> References: <20200707225021.200906-1-peterx@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 1724418038E60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use the general page fault accounting by passing regs into handle_mm_faul= t(). Add the missing PERF_COUNT_SW_PAGE_FAULTS perf events too. Note, the oth= er two perf events (PERF_COUNT_SW_PAGE_FAULTS_[MAJ|MIN]) were done in handle_mm_= fault(). CC: Richard Henderson CC: Ivan Kokshaysky CC: Matt Turner CC: linux-alpha@vger.kernel.org Signed-off-by: Peter Xu --- arch/alpha/mm/fault.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/alpha/mm/fault.c b/arch/alpha/mm/fault.c index 1983e43a5e2f..09172f017efc 100644 --- a/arch/alpha/mm/fault.c +++ b/arch/alpha/mm/fault.c @@ -25,6 +25,7 @@ #include #include #include +#include =20 extern void die_if_kernel(char *,struct pt_regs *,long, unsigned long *)= ; =20 @@ -116,6 +117,7 @@ do_page_fault(unsigned long address, unsigned long mm= csr, #endif if (user_mode(regs)) flags |=3D FAULT_FLAG_USER; + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, address); retry: mmap_read_lock(mm); vma =3D find_vma(mm, address); @@ -148,7 +150,7 @@ do_page_fault(unsigned long address, unsigned long mm= csr, /* If for any reason at all we couldn't handle the fault, make sure we exit gracefully rather than endlessly redo the fault. */ - fault =3D handle_mm_fault(vma, address, flags, NULL); + fault =3D handle_mm_fault(vma, address, flags, regs); =20 if (fault_signal_pending(fault, regs)) return; @@ -164,10 +166,6 @@ do_page_fault(unsigned long address, unsigned long m= mcsr, } =20 if (flags & FAULT_FLAG_ALLOW_RETRY) { - if (fault & VM_FAULT_MAJOR) - current->maj_flt++; - else - current->min_flt++; if (fault & VM_FAULT_RETRY) { flags |=3D FAULT_FLAG_TRIED; =20 --=20 2.26.2