From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E857C433E3 for ; Wed, 8 Jul 2020 07:21:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D610920739 for ; Wed, 8 Jul 2020 07:21:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kAqV25Aj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D610920739 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 671638D0028; Wed, 8 Jul 2020 03:21:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9678D000D; Wed, 8 Jul 2020 03:21:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 424498D0028; Wed, 8 Jul 2020 03:21:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 21AE88D000D for ; Wed, 8 Jul 2020 03:21:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DA7B41EE6 for ; Wed, 8 Jul 2020 07:21:39 +0000 (UTC) X-FDA: 77014063518.20.idea22_0a0fe4b26ebb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id ABC4E180C0609 for ; Wed, 8 Jul 2020 07:21:39 +0000 (UTC) X-HE-Tag: idea22_0a0fe4b26ebb X-Filterd-Recvd-Size: 4080 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Wed, 8 Jul 2020 07:21:39 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id p3so21237387pgh.3 for ; Wed, 08 Jul 2020 00:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ogE4o4WvozDyfT3UOGRAcLiOplwqpD6nSKH21zq1lM8=; b=kAqV25AjWwvyshU6McP4HVGr65hx8/Op0fGWcZQqPVJylcSASp+dRZP961RdArQbu7 Y3ATp7t5QSVVH1fQDEOcHyYQ9MQHzcDnAcp2Hhzn4tW/CO4gKza0v6cQ/H3JND9zN8Rp K5TvTMSldPNMCIUxlCmRO6xs7jSUXNXcIPgE5sWeWPiQP0cLXrGiiC6GYf/qYuBlZp99 X5+wsArr5oaRRRwtZQ2WAyPt6ppKcgQwoURXbCF+y63+//38amRsA715cHNQXyFJD2Lz +EuK+pwgl7cQwqnzWh9mY2K3JBWYDtcsGo/o1gCE3ccbalCPKuTC+6iqNpopYctuf0Dv mRoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ogE4o4WvozDyfT3UOGRAcLiOplwqpD6nSKH21zq1lM8=; b=kcs3RT94BhDSUM/MCtgaMwVV0SWCl7tVQIwV6DmxwgNhTOTL+njyyk98+xJDAneq01 3CcFwMx0N3NsqyM6jbRdzs04YfMNDrG23gl9S+Tl74UUx8XGIqiab9YxowR3wRHJTuNo 3ja0nf+ScQY3P3ZGuaogALRZtk0sEaELiMMJGJMU12bnU/JqAd/FndFwPjDbj4IU91dz b6cee+0AoT97n6o/6g5ipd9YRd7TbvUeXqZAvgY5iHcCEt13W136D5uPmYWVuYqd3YiY H7gei/NGRrzFWEaUXIHXikA61r1D6wEuYb4XdOs+Uke/4JHG6g5VqA5qWQa6GL7V8+6r U6Dw== X-Gm-Message-State: AOAM531MA1RImsFHM5Sg13gAkKCPX0rjUuTpwSjIzaKqCBltT1pb/kFk oZARKquJVYd5o2Hb4eiIay4= X-Google-Smtp-Source: ABdhPJwrlbUsS7TeV9hM3LoBNXqKgo9gOcQwCKsO/qWe2aHmCDEm2vYvUkIhJFFrYMBZX76HoZx8Qg== X-Received: by 2002:a65:4149:: with SMTP id x9mr49796092pgp.424.1594192898437; Wed, 08 Jul 2020 00:21:38 -0700 (PDT) Received: from js1304-desktop ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id mu17sm4886807pjb.53.2020.07.08.00.21.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jul 2020 00:21:38 -0700 (PDT) Date: Wed, 8 Jul 2020 16:21:33 +0900 From: Joonsoo Kim To: Michal Hocko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@lge.com, Vlastimil Babka , Christoph Hellwig , Roman Gushchin , Mike Kravetz , Naoya Horiguchi Subject: Re: [PATCH v4 07/11] mm/gup: use a standard migration target allocation callback Message-ID: <20200708072132.GE16543@js1304-desktop> References: <1594107889-32228-1-git-send-email-iamjoonsoo.kim@lge.com> <1594107889-32228-8-git-send-email-iamjoonsoo.kim@lge.com> <20200707114614.GK5913@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200707114614.GK5913@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-Rspamd-Queue-Id: ABC4E180C0609 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 07, 2020 at 01:46:14PM +0200, Michal Hocko wrote: > On Tue 07-07-20 16:44:45, Joonsoo Kim wrote: > [...] > > @@ -1551,9 +1552,12 @@ struct page *alloc_migration_target(struct page *page, unsigned long private) > > > > gfp_mask |= htlb_alloc_mask(h); > > return alloc_huge_page_nodemask(h, nid, mtc->nmask, > > - gfp_mask, false); > > + gfp_mask, mtc->skip_cma); > > } > > > > + if (mtc->skip_cma) > > + flags = memalloc_nocma_save(); > > + > > As already mentioned in previous email this is a completely wrong usage > of the scope API. The scope should be defined by the caller and this > should be all transparent by the allocator layer. Okay. Like as newly sent patch for 04/11, this patch will also be changed. Thanks.