Re: [hnaz-linux-mm:master 82/248] arch/powerpc/mm/nohash/tlb.c:409:6: warning: no previous prototype for 'tlb_flush_pgtable'

[Mike Rapoport <rppt@linux.ibm.com>]

On Wed, Jul 08, 2020 at 10:17:08PM +0800, kernel test robot wrote:
> tree:   https://github.com/hnaz/linux-mm master
> head:   7ffdd789c7f570af323ad890ab09118af2e3b0d9
> commit: 9939c9934d2e30d1a3b3f7d85572ce3d5f2b0c90 [82/248] mm: remove unneeded includes of <asm/pgalloc.h>
> config: powerpc-randconfig-r032-20200708 (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 9939c9934d2e30d1a3b3f7d85572ce3d5f2b0c90
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> arch/powerpc/mm/nohash/tlb.c:409:6: warning: no previous prototype for 'tlb_flush_pgtable' [-Wmissing-prototypes]
>      409 | void tlb_flush_pgtable(struct mmu_gather *tlb, unsigned long address)
>          |      ^~~~~~~~~~~~~~~~~

Here is the fix:

From f3c049a1b49f6ed92a61746e05a0087943d79254 Mon Sep 17 00:00:00 2001
From: Mike Rapoport <rppt@linux.ibm.com>
Date: Wed, 8 Jul 2020 18:10:47 +0300
Subject: [PATCH] powerpc: fix compilation warning caused by missing include of
 asm/pgalloc.h

Recent rework of asm/pgalloc.h caused a compilation warning reported by
kbuild bot:

All warnings (new ones prefixed by >>):

>> arch/powerpc/mm/nohash/tlb.c:409:6: warning: no previous prototype for
>> 'tlb_flush_pgtable' [-Wmissing-prototypes]
     409 | void tlb_flush_pgtable(struct mmu_gather *tlb, unsigned long address)
         |      ^~~~~~~~~~~~~~~~~

Add missing include of asm/pgtable.h to arch/powerpc/mm/nohash/tlb.c to
make tlb_flush_pgtable() prototype visible there.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/powerpc/mm/nohash/tlb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/mm/nohash/tlb.c b/arch/powerpc/mm/nohash/tlb.c
index 696f568253a0..14514585db98 100644
--- a/arch/powerpc/mm/nohash/tlb.c
+++ b/arch/powerpc/mm/nohash/tlb.c
@@ -34,6 +34,7 @@
 #include <linux/of_fdt.h>
 #include <linux/hugetlb.h>
 
+#include <asm/pgalloc.h>
 #include <asm/tlbflush.h>
 #include <asm/tlb.h>
 #include <asm/code-patching.h>
-- 
2.26.2