From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF632C433DF for ; Thu, 9 Jul 2020 14:02:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 847BD20708 for ; Thu, 9 Jul 2020 14:02:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 847BD20708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C13E6B0007; Thu, 9 Jul 2020 10:02:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14CE66B0008; Thu, 9 Jul 2020 10:02:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 014726B000A; Thu, 9 Jul 2020 10:02:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id DC08C6B0007 for ; Thu, 9 Jul 2020 10:02:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 14274181AEF1A for ; Thu, 9 Jul 2020 14:02:09 +0000 (UTC) X-FDA: 77018701578.03.join10_6011cf026ec6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id A98C228A052 for ; Thu, 9 Jul 2020 14:01:56 +0000 (UTC) X-HE-Tag: join10_6011cf026ec6 X-Filterd-Recvd-Size: 2861 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 14:01:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 03E3D68AEF; Thu, 9 Jul 2020 16:01:46 +0200 (CEST) Date: Thu, 9 Jul 2020 16:01:45 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: remove dead bdi congestion leftovers Message-ID: <20200709140145.GA3068@lst.de> References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: A98C228A052 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 09, 2020 at 07:58:58AM -0600, Jens Axboe wrote: > On 7/8/20 11:32 PM, Christoph Hellwig wrote: > > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: > >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: > >>> Hi Jens, > >>> > >>> we have a lot of bdi congestion related code that is left around wi= thout > >>> any use. This series removes it in preparation of sorting out the = bdi > >>> lifetime rules properly. > >> > >> Please run series like this through a full compilation, for both thi= s one > >> and the previous series I had to fix up issues like this: > >> > >> drivers/md/bcache/request.c: In function =E2=80=98bch_cached_dev_req= uest_init=E2=80=99: > >> drivers/md/bcache/request.c:1233:18: warning: unused variable =E2=80= =98g=E2=80=99 [-Wunused-variable] > >> 1233 | struct gendisk *g =3D dc->disk.disk; > >> | ^ > >> drivers/md/bcache/request.c: In function =E2=80=98bch_flash_dev_requ= est_init=E2=80=99: > >> drivers/md/bcache/request.c:1320:18: warning: unused variable =E2=80= =98g=E2=80=99 [-Wunused-variable] > >> 1320 | struct gendisk *g =3D d->disk; > >> | ^ > >> > >> Did the same here, applied it. > >=20 > > And just like the previous one I did, and the compiler did not compla= in. > > There must be something about certain gcc versions not warning about > > variables that are initialized but not otherwise used. >=20 > Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit > these cases for me, not sure why gcc-10 doesn't. And the ones quoted > above are about as trivial as they can get. gcc-9.3 from Debian -testing. And yes, I'm really surprised it didn't find those.